Skip to content

test: googleAnalytics set #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 3, 2021
Merged

test: googleAnalytics set #185

merged 8 commits into from
Sep 3, 2021

Conversation

MiryangJung
Copy link
Member

@MiryangJung MiryangJung commented Sep 1, 2021

Description

googleAnalytics set test 코드를 추가하였습니다.

Help Wanted 👀

setname 이 옵셔널이라서 name의 유무에 따라 console.info가 다르게 나타납니다.

react-analytics-provider/pull/113

if(name === undefined) {
 console.info(`✅GA: set`, params);
 ...생략
}
else {
 console.info(`✅GA: set ${name}`, params);
 ...생략
}

console.info 까지도 test를 진행해야 할까요?

Related Issues

resolve #151
fix #

Checklist ✋

  • PR 타이틀을 {PR type}: {PR title}로 맞췄습니다. (type 예시: feat | fix | BREAKING CHANGE | chore | ci | docs | style | refactor | perf | test) (참고: conventional commits)
  • 모든 변경점들을 확인했으며 적절히 설명했습니다.
  • 빌드와 테스트가 정상적으로 수행됨을 확인했습니다. (yarn build, yarn test)
  • 깃헙 이슈를 연결하겠습니다. (커밋에 resolve #이슈넘버 적거나 PR생성 후 Linked Issue 추가)

@MiryangJung MiryangJung self-assigned this Sep 1, 2021
@MiryangJung MiryangJung marked this pull request as ready for review September 1, 2021 12:16
Copy link
Contributor

@sensecodevalue sensecodevalue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 고생하셨습니다.
다만! 이번에 확인해 보니까 console.info에 찍히는 내용도 조금씩 달라지는 것으로 보아 출력 문 또한 확인해야되나? 하는 생각이 듭니다! 디스커션해보아야겠어용!

@MiryangJung
Copy link
Member Author

다만! 이번에 확인해 보니까 console.info에 찍히는 내용도 조금씩 달라지는 것으로 보아 출력 문 또한 확인해야되나? 하는 생각이 듭니다! 디스커션해보아야겠어용!

Help Wanted에 내용을 추가해두었습니다. 감사합니다 ㅎㅎ

Copy link
Member

@greatSumini greatSumini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅎㅎ 고생하셨습니다~

@greatSumini
Copy link
Member

고생하셨습니다 ㅎㅎ

@MiryangJung MiryangJung merged commit c9c3186 into main Sep 3, 2021
@MiryangJung MiryangJung deleted the feat/151 branch September 3, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

googleAnalytics.set 테스트 코드 작성
3 participants