-
Notifications
You must be signed in to change notification settings - Fork 19
test: googleAnalytics set #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 고생하셨습니다.
다만! 이번에 확인해 보니까 console.info에 찍히는 내용도 조금씩 달라지는 것으로 보아 출력 문 또한 확인해야되나? 하는 생각이 듭니다! 디스커션해보아야겠어용!
Help Wanted에 내용을 추가해두었습니다. 감사합니다 ㅎㅎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㅎㅎ 고생하셨습니다~
Co-authored-by: Choi Sumin <[email protected]>
고생하셨습니다 ㅎㅎ |
Description
googleAnalytics set test 코드를 추가하였습니다.
Help Wanted 👀
set
은 name 이 옵셔널이라서 name의 유무에 따라 console.info가 다르게 나타납니다.console.info 까지도 test를 진행해야 할까요?
Related Issues
resolve #151
fix #
Checklist ✋
{PR type}: {PR title}
로 맞췄습니다. (type 예시: feat | fix | BREAKING CHANGE | chore | ci | docs | style | refactor | perf | test) (참고: conventional commits)yarn build
,yarn test
)