Skip to content

feat(server): generic GraphQL WS subscription support #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 7, 2023

Conversation

dariuszkuc
Copy link
Collaborator

@dariuszkuc dariuszkuc commented Jun 30, 2023

Add GraphQL WS subscription protocol implementation to the graphql-kotlin-server. Both Ktor and Spring servers can now use the same Flow based implementation.

Spring server defaults to the new graphql-transport-ws protocol. In order to opt-in to use the legacy Apollo subscription-transport-ws you need to explicitly specify graphql.subscriptions.protocol=APOLLO_SUBSCRIPTIONS_WS property.

Deprecated all existing Spring classes related to Apollo subscription-transport-ws protocol.

@dariuszkuc dariuszkuc added type: enhancement New feature or request changes: minor Changes require a minor version module: server Issue affects the server code labels Jul 6, 2023
@dariuszkuc dariuszkuc enabled auto-merge (squash) July 6, 2023 20:03
@dariuszkuc dariuszkuc changed the title feat: generic GraphQL WS subscription support feat(server): generic GraphQL WS subscription support Jul 6, 2023
@dariuszkuc dariuszkuc disabled auto-merge July 6, 2023 21:08
@dariuszkuc dariuszkuc enabled auto-merge (squash) July 6, 2023 21:08
@dariuszkuc dariuszkuc merged commit 74ddab7 into ExpediaGroup:master Jul 7, 2023
@dariuszkuc dariuszkuc deleted the subscriptions branch July 7, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version module: server Issue affects the server code type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants