Skip to content

feat: subscriptions #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2019
Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented May 6, 2019

Fixes #155

Example using a Websocket test client

Screen Shot 2019-05-05 at 8 33 26 PM

@codecov
Copy link

codecov bot commented May 6, 2019

Codecov Report

Merging #215 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #215      +/-   ##
============================================
+ Coverage     98.36%   98.43%   +0.06%     
- Complexity      171      178       +7     
============================================
  Files            55       57       +2     
  Lines           552      574      +22     
  Branches         96       98       +2     
============================================
+ Hits            543      565      +22     
  Misses            4        4              
  Partials          5        5
Impacted Files Coverage Δ Complexity Δ
...ia/graphql/exceptions/InvalidQueryTypeException.kt 100% <100%> (ø) 1 <1> (ø) ⬇️
...expedia/graphql/generator/types/FunctionBuilder.kt 100% <100%> (ø) 13 <3> (+1) ⬆️
.../com/expedia/graphql/hooks/SchemaGeneratorHooks.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...otlin/com/expedia/graphql/SchemaGeneratorConfig.kt 100% <100%> (ø) 5 <0> (ø) ⬇️
src/main/kotlin/com/expedia/graphql/toSchema.kt 100% <100%> (ø) 0 <0> (ø) ⬇️
...hql/exceptions/InvalidSubscriptionTypeException.kt 100% <100%> (ø) 1 <1> (?)
...dia/graphql/generator/types/SubscriptionBuilder.kt 100% <100%> (ø) 5 <5> (?)
...n/com/expedia/graphql/generator/SchemaGenerator.kt 97.56% <100%> (+0.12%) 17 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51ad9b...ce2e142. Read the comment docs.

Copy link
Contributor

@rickfast rickfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariuszkuc dariuszkuc merged commit 976052a into ExpediaGroup:master May 7, 2019
@smyrick smyrick deleted the subscribtions branch May 7, 2019 17:28
@smyrick smyrick added changes: minor Changes require a minor version type: enhancement New feature or request labels May 7, 2019
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* feat: subscriptions

* rename extension method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Support subscriptions
3 participants