Subscription refactor #512
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Refactor of the websocket logic to keep sending the keep alive messages until the client calls
connection terminate
.Clients can open a connection with
GQL_CONNECTION_INIT
but never callGQL_START
. The keep alive messages from the server should still be sent in that case, which also means we don't need to save the websocket session. We can just stop the session only onGQL_CONNECTION_TERMINATE
This also cleans up the keep alive connections after
GQL_STOP
is sent by the client or the server sendsGQL_CONNECTION_ERROR
https://github.com/apollographql/subscriptions-transport-ws/blob/master/PROTOCOL.md
🔗 Related Issues