Fix subscription caching logic #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
added
type: bug
|
Just build the source branch, and then the test related to #499. Still the same result after about 120 subscriptions that have been started and stopped the websocket becomes unresponsive. |
added 2 commits
December 16, 2019 12:48
Move the saving of subscriptions to a separate class so we can vefify the logic with unit tests and simplify the ApolloSubscriptionProtocolHandler. This also exposed a bug that we were not saving the operation subscriptions to be stopped properly. This is now covered by the unit tests
Prioritize clearing memory over saving the small amount of operation we have to perform is the session stays open but there is no active operations
smyrick
force-pushed
the
perf-test-fix
branch
from
bb0f97d to
0ebf985
Compare
dariuszkuc
approved these changes
Dec 16, 2019
dariuszkuc
approved these changes
Dec 16, 2019
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* Refactor subscription caching logic Move the saving of subscriptions to a separate class so we can vefify the logic with unit tests and simplify the ApolloSubscriptionProtocolHandler. This also exposed a bug that we were not saving the operation subscriptions to be stopped properly. This is now covered by the unit tests * Clear cache of operations if no more left Prioritize clearing memory over saving the small amount of operation we have to perform is the session stays open but there is no active operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Please merge this first: #514
Move the saving of subscriptions to a separate class so we can verify the logic with unit tests and simplify the
ApolloSubscriptionProtocolHandler. This also exposed a bug that we were not saving the operation subscriptions to be stopped properly. This is now covered by the unit tests🔗 Related Issues