Prevent starting second subscription with the same id #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrick
suggested changes
Dec 18, 2019
...server/src/main/kotlin/com/expediagroup/graphql/spring/model/SubscriptionOperationMessage.kt
Outdated
Show resolved
Hide resolved
smyrick
reviewed
Dec 18, 2019
...c/main/kotlin/com/expediagroup/graphql/spring/execution/ApolloSubscriptionProtocolHandler.kt
Show resolved
Hide resolved
…lete message as it's not needed, and probably preventing flux from closing.
gklijs
force-pushed
the
subscription-fix
branch
from
d23c828 to
ada92b1
Compare
smyrick
previously requested changes
Dec 18, 2019
.../src/main/kotlin/com/expediagroup/graphql/spring/execution/ApolloSubscriptionSessionState.kt
Show resolved
Hide resolved
smyrick
dismissed
their stale review
This does follow the spec for subscriptions
smyrick
changed the title
smyrick
added
changes: patch
smyrick
approved these changes
Dec 18, 2019
|
Thanks for your help on the subscriptions @gklijs. If anyone else has any comments or bugs on subscriptions please comment below. We are not currently using them at ExpediaGroup so we don't have the traffic to verify but we still want this library to support subscriptions 100% |
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
…lete message as it's not needed, and probably preventing flux from closing. (ExpediaGroup#520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#141 # 📝 Description
Prevent starting second subscription with the same id, remove he complete message as it's not needed, and probably preventing flux from closing. Validated this will solve the problems, as it finally ran longer than 2 minutes.
🔗 Related Issues
#499