Skip to content

Update spring server overview page #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Jan 7, 2020

📝 Description

Add some images and more details, copying information from https://medium.com/expedia-group-tech/creating-a-reactive-graphql-server-with-spring-boot-and-kotlin-54aca7316470

🔗 Related Issues

Revamp of #538

🖼 New look

Screen Shot 2020-01-07 at 10 49 03 AM

@smyrick smyrick added the type: documentation Documentation or test changes label Jan 7, 2020
@ghost
Copy link

ghost commented Jan 7, 2020

This change is an improvement on several fronts. I'm proposing an addition to specifically address #537.

There was text in #538 to address the specific problem encountered in #537, which I don't see in any of this. (Possibly my ignorance is showing.) Should there be specific mention of Spring WebMVC and/or Spring Servlet somewhere here, even if it's only pointing out that we're not giving examples of those technologies, and users of those technologies will encounter issues they'll have to resolve for themselves? It's not clear to me whether the proposed changes here would prevent someone else from running into the same issue as #537.

@smyrick
Copy link
Contributor Author

smyrick commented Jan 7, 2020

@EXPErdelfavero Added a back a full sentence about the dropping of Spring Web MVC. We did make some assumptions that anyone who has developed on a Spring server knows that "reactive" means they cannot use servlet. Hopefully the above sentence clarifies that without being such a flag.

We want to save the yellow block NOTE: sections for something of higher priority.

@ghost
Copy link

ghost commented Jan 7, 2020

@smyrick Thanks. I'd review and approve the text, but hesitate because I've just demonstrated my lack of qualification to perform a technical review. :) The text looks fine from an editorial standpoint.

@dariuszkuc dariuszkuc merged commit 5c08ad3 into ExpediaGroup:master Jan 7, 2020
@smyrick smyrick deleted the spring-server-setup-docs branch January 7, 2020 22:50
dariuszkuc added a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Update spring server overview page

Add some images and more details, copying information from https://medium.com/expedia-group-tech/creating-a-reactive-graphql-server-with-spring-boot-and-kotlin-54aca7316470

* Add dropping of spring webmvc

* Update docs/spring-server/spring-overview.md

Co-Authored-By: Dariusz Kuc <[email protected]>

Co-authored-by: Dariusz Kuc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation or test changes
Development

Successfully merging this pull request may close these issues.

2 participants