BREAKING CHANGE: Make the KotlinDataFetcherFactoryProvider nullable #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We made the DataFetcher nullable in this change ExpediaGroup#613, so this lines up to match the same types in graphql-java
smyrick
added
type: bug
|
lgtm |
tapaderster
approved these changes
Feb 27, 2020
dariuszkuc
pushed a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
We made the DataFetcher nullable in this change ExpediaGroup#613, so this lines up to match the same types in graphql-java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
We made the
FunctionDataFetcherreturn nullable in this change #613. That is a good change but I only realized after integrating into our internal SDK that this also impacts theKotlinDataFetcherFactoryProvider.KotlinDataFetcherFactoryProviderreturns aDataFetcherFactory, and in graphql-java those are supposed to implement the same types that theDataFetcherreturns. So this change fixed that to match the same types in graphql-java.This is a breaking change as the interface signature has now been changed.
🔗 Related Issues
Data Fetcher returns nullable here: #613