Skip to content

Allow for custom subscription return types #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

smyrick
Copy link
Contributor

@smyrick smyrick commented Mar 20, 2020

📝 Description

Allow for the use of custom types for subscriptions. This requires that you override two hooks, and the execution strategy, but at least this is now possible and we don't have to worry about blocking others from using their own types

🔗 Related Issues

#629

@smyrick smyrick added type: enhancement New feature or request changes: minor Changes require a minor version labels Mar 20, 2020
Copy link
Collaborator

@dariuszkuc dariuszkuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariuszkuc dariuszkuc merged commit 15810a7 into ExpediaGroup:master Mar 21, 2020
@smyrick smyrick deleted the custom-subscription-types-hooks branch March 21, 2020 17:33
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* Allow for custom subscription return types

* Update subscription docs

* Fix linter

Co-authored-by: Shane Myrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes: minor Changes require a minor version type: enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants