[client] update ScalarConverter to accept any objects #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariuszkuc
added
type: bug
|
Verified locally with |
Custom GraphQL scalars can be serialized as any of the other built-in scalars (i.e. int, float, etc). Changed method signatures to accept `Any` when converting to scalar, and produce `Any` when generating JSON value.
dariuszkuc
force-pushed
the
scalar_converter
branch
from
148fd96 to
b36cc67
Compare
smyrick
approved these changes
Aug 26, 2020
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 3, 2020
…aGroup#819)" This reverts commit 1804e6a
smyrick
pushed a commit
to smyrick/graphql-kotlin
that referenced
this pull request
Sep 18, 2020
* [client] update ScalarConverter to accept any objects Custom GraphQL scalars can be serialized as any of the other built-in scalars (i.e. int, float, etc). Changed method signatures to accept `Any` when converting to scalar, and produce `Any` when generating JSON value. * update docs to match change to any
huehnerlady
pushed a commit
to huehnerlady/graphql-kotlin
that referenced
this pull request
Oct 16, 2020
* [client] update ScalarConverter to accept any objects Custom GraphQL scalars can be serialized as any of the other built-in scalars (i.e. int, float, etc). Changed method signatures to accept `Any` when converting to scalar, and produce `Any` when generating JSON value. * update docs to match change to any
benimario
added a commit
to benimario/graphql-kotlin
that referenced
this pull request
Oct 30, 2020
dariuszkuc
added a commit
to dariuszkuc/graphql-kotlin
that referenced
this pull request
Aug 5, 2022
* [client] update ScalarConverter to accept any objects Custom GraphQL scalars can be serialized as any of the other built-in scalars (i.e. int, float, etc). Changed method signatures to accept `Any` when converting to scalar, and produce `Any` when generating JSON value. * update docs to match change to any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Custom GraphQL scalars can be serialized as any of the other built-in scalars (i.e. int, float, etc). Changed method signatures to accept
Anywhen converting to scalar, and produceAnywhen generating JSON value.🔗 Related Issues
Resolves #816