fix: return launchOptions so they are applied #186
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRSgit
approved these changes
Nov 29, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
## [3.2.2](v3.2.1...v3.2.2) (2022-11-29) ### Bug Fixes * return launchOptions so they are applied ([#186](#186)) ([b1b9056](b1b9056))
|
🎉 This PR is included in version 3.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, and thanks a bunch for this great tool 😄
Summary
According to the Cypress documentation the
launchOptionsneed to be returned for them to be used. Can confirm.Background
I ran into problems in fremtind/jokul#3270 (Norwegian repo, sorry for the language barrier) where I'm looking to adopt this plugin as a replacement for
cypress-plugin-snapshots.We use Cypress to also run visual regression tests in forced-colors mode. We solve this with an environment variable and this patch1 for
cypress-plugin-snapshots. When I applied a similar patch to this plugin, the launch option was not applied.Once I added the
returnstatement to my patch the launch options worked as expected.Footnotes
We patch because Cypress doesn't support registering multiple
on(...)functions to the same event, such ason("before:browser:launch", ...). There's an open issue for this limitation in the Cypress repo. ↩