Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing #1

Merged
merged 40 commits into from
Dec 23, 2019
Merged

Syncing #1

merged 40 commits into from
Dec 23, 2019

Conversation

FanJups
Copy link
Owner

@FanJups FanJups commented Dec 23, 2019

No description provided.

jingping2015 and others added 30 commits May 20, 2019 15:49
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D15422916

fbshipit-source-id: 0ae1744d
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D15532082

fbshipit-source-id: 8d7c329b
Summary:
Notes:
Should only run on master build
Does not perform code signing
Skips any tests for now
Pull Request resolved: #240

Differential Revision: D15809134

Pulled By: joesus

fbshipit-source-id: 668472b1
Summary: Pull Request resolved: #239

Differential Revision: D15631196

Pulled By: joesus

fbshipit-source-id: 818dbb63
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D16188377

fbshipit-source-id: 255e23d0
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D16291693

fbshipit-source-id: 14d4cec2
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D16520434

fbshipit-source-id: 404764f3
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D16547671

fbshipit-source-id: ee1fd14b
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D16677922

fbshipit-source-id: e0ec6fde
Summary: Pull Request resolved: #250

Reviewed By: joesus

Differential Revision: D16706193

Pulled By: jingping2015

fbshipit-source-id: 0d94b265
Summary:
endpoint https://developers.facebook.com/docs/marketing-api/reference/ad-campaign-group/copies/#Creating
return campain like
```
Struct {
copied_campaign_id: numeric string,
ad_object_ids: List [
Struct {
ad_object_type: enum {unique_adcreative, ad, ad_set, campaign, opportunities, topline, ad_account},
source_id: numeric string,
copied_id: numeric string,
}
],
}
```

when we convert json to a object, `copied_campaign_id` should be able to map to `id`

Reviewed By: joesus

Differential Revision: D16657143

fbshipit-source-id: b8521334
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D16821257

fbshipit-source-id: 8d5174f0
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D16927825

fbshipit-source-id: dd20eb2e
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D17097830

fbshipit-source-id: 506b0e98
Summary: As title

Reviewed By: YOUDAN

Differential Revision: D17208797

fbshipit-source-id: 21d6a040
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D17326715

fbshipit-source-id: 04a211f5
Summary:
`source` params is valid param for adaccount advideo create : https://developers.facebook.com/docs/marketing-api/reference/ad-account/advideos/#Creating

in PHP SDK,  this should be a `File` param in SDK, otherwise PHP SDK will not be proper pass to API.
This diff fix the issue .

Reviewed By: selia

Differential Revision: D17437116

fbshipit-source-id: 93c9085c
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D17503729

fbshipit-source-id: eb27821e
Summary:
#235

Looks like we don't need `NULL` for enum class

Reviewed By: joesus

Differential Revision: D17242244

fbshipit-source-id: 33c2cc4c
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D17820620

fbshipit-source-id: 1ebd7ce6
Summary: Strongly typed Server-Side API for web. New API endpoint for S2S

Differential Revision: D17821006

fbshipit-source-id: 44bd0ee2
Summary: Java Server-Side API doc fix

Reviewed By: jingping2015

Differential Revision: D18002421

fbshipit-source-id: 2329f3e6
Reviewed By: joesus

Differential Revision: D17784468

fbshipit-source-id: a03cbfa2
Summary:
Add function to get appID from accesstoken
Add send report function in CrashReporter

Reviewed By: joesus

Differential Revision: D17819942

fbshipit-source-id: 986324cc
Summary:
Normalization for User Data fields fixing some noob (fb git)errors on the previous diff

https://our.intern.facebook.com/intern/diff/D18013036/?entry_point=1

Differential Revision: D18031058

fbshipit-source-id: 666fdb17
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D18095474

fbshipit-source-id: 3921b213
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D18211191

fbshipit-source-id: a2119ee1
Summary: Update changelog

Reviewed By: joesus

Differential Revision: D18213265

fbshipit-source-id: d4bc4b56
Summary: Initialize CrashReporter when start APIContext

Reviewed By: joesus

Differential Revision: D18263974

fbshipit-source-id: 4116f7d9
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D18322410

fbshipit-source-id: a5c94be0
Jameel Mohamed and others added 10 commits November 6, 2019 17:05
Summary: Server-Side Java API example.

Differential Revision: D18363010

fbshipit-source-id: f7f2b0b0
Summary: Server-Side API convert primitive types to objects. This will avoid premitive type default value. Also changed BigDecimal to Float.

Reviewed By: jingping2015

Differential Revision: D18379830

fbshipit-source-id: b9a88c57
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D18414855

fbshipit-source-id: 11b9cd27
…ject

Summary: Server side java api adding parameterized constructor to all model object

Reviewed By: vinothsa

Differential Revision: D18533834

fbshipit-source-id: 09f340c5
Summary:
Pull Request resolved: #262

Pull Request resolved: facebook/facebook-business-sdk-codegen#8

Filled out function *getHeader()* in APIException class in order to provide header information

Reviewed By: jingping2015

Differential Revision: D18544054

fbshipit-source-id: 5e08e303
Summary: Fixed typo from 'sucess' to 'success'

Reviewed By: joesus

Differential Revision: D18620278

fbshipit-source-id: c9b0ee22
Summary:
This diff relates to issue 236 on the GitHub repo **facebook/facebook-java-business-sdk** :
#236

Made omit_response_on_success configurable for addToBatch method in APIRequest

Reviewed By: jingping2015

Differential Revision: D18814304

fbshipit-source-id: d27a825d
Summary: ignore-conflict-markers

Reviewed By: jingping2015

Differential Revision: D18904514

fbshipit-source-id: 745372d6
Summary:
1. Added plugin in POM.xml in order to compile Kotlin code in src/test file
2. Added relative dependencies for Junit test and Mock framework ( Mockk )
3. Added Junit test for APIContext class using Kotlin

Reviewed By: jingping2015

Differential Revision: D18732807

fbshipit-source-id: 54b40c66
Summary: Server-side Java API added search_string to CustomData.

Reviewed By: mynameisram

Differential Revision: D19216647

fbshipit-source-id: 7a6a262b
@FanJups FanJups merged commit 36fc82c into FanJups:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants