Skip to content

Project needs to set minimal rust version to Cargo.toml #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qarmin opened this issue Dec 29, 2024 · 2 comments
Closed

Project needs to set minimal rust version to Cargo.toml #11

qarmin opened this issue Dec 29, 2024 · 2 comments

Comments

@qarmin
Copy link

qarmin commented Dec 29, 2024

I wanted to compile project on rust 1.81.0, but I got error

error[E0658]: precise captures on `impl Trait` are experimental
   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/vid_dup_finder_common-0.2.0/src/crop.rs:135:83
    |
135 |     pub fn enumerate_coords_excluded(&self) -> impl Iterator<Item = (u32, u32)> + use<> {
    |                                                                                   ^^^
    |
    = note: see issue #123432 <https://github.com/rust-lang/rust/issues/123432> for more information

For more information about this error, try `rustc --explain E0658`.
error: could not compile `vid_dup_finder_common` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

rust-lang/rust#123432 - seems to be closed in 1.82.0 version

@Farmadupe
Copy link
Owner

Farmadupe commented Dec 29, 2024

I do not currently have testing set up to be able to verify any MSRV attribute that I apply to cargo.toml. So intead of making a promise that I can't keep I'd prefer to fix the issue by removing the use<>. Is this OK for you ?

Farmadupe added a commit that referenced this issue Dec 29, 2024
@qarmin
Copy link
Author

qarmin commented Dec 29, 2024

In my case it doesn't cause any problems (this change will probably bring the required version of rust down to <=1.80.0, and I'm tied to at least version 1.81.0 anyway due to other dependencies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants