Skip to content

Support @JsonValue for key serialization #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cowtowncoder opened this issue Aug 13, 2012 · 5 comments
Closed

Support @JsonValue for key serialization #47

cowtowncoder opened this issue Aug 13, 2012 · 5 comments
Milestone
2.5.0

Comments

@cowtowncoder
Copy link
Member

Currently Map key types support a subset of annotations, such as:

  • JsonSerialize and JsonDeserialize properties keyAs and keyUsing work
  • @JsonCreator works for indicating single-String-arg constructors, factory methods

But one annotation that would seem like an obvious addition, @JsonValue, is not yet supported.
It should.
@cowtowncoder cowtowncoder mentioned this issue Jan 3, 2013
Closed
@stevenschlansker
Copy link

It would be nice that when this support appears, we check that it works with jackson-datatype-guava for Multimap keys. (See the issue linked immediately previous to this comment.)

@cowtowncoder
Copy link
Member Author

Agreed.

If anyone has cycles to add a "failing" test (one that resides under "src/test/java/.../failing, and configured to be by-passed for regular build) that would be appreciated.

stevenschlansker pushed a commit to stevenschlansker/jackson-databind that referenced this issue Jan 3, 2013
Failing test case for Issue FasterXML#47: Map key @JsonValue serializ…
80d0434 
…ation
@stevenschlansker
Copy link

Done, see above.

@cowtowncoder cowtowncoder mentioned this issue Feb 25, 2014
Closed
cowtowncoder added a commit that referenced this issue Mar 14, 2014
@cowtowncoder
Clean up test for #47; have a look at how implement, realizing that i…
a6ed7f7 
…t's... a pain to implement.
@joelittlejohn joelittlejohn mentioned this issue May 27, 2014
Closed
@cowtowncoder cowtowncoder added this to the 2.5.0 milestone Dec 13, 2014
@stevenschlansker
Copy link

Nice!

@cowtowncoder
Copy link
Member Author

Finally went back. Not very difficult to do. Still need to see guava side.

christophercurrie pushed a commit to christophercurrie/jackson-databind that referenced this issue Jul 19, 2015
@cowtowncoder
Finished FasterXML#47 implementation
0a39869
@cowtowncoder cowtowncoder mentioned this issue Oct 10, 2019
Closed
@cowtowncoder cowtowncoder mentioned this issue Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
2 participants
@cowtowncoder @stevenschlansker