Skip to content

Case-insensitive boolean deserialization #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Case-insensitive boolean deserialization #2132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/fasterxml/jackson/databind/deser/std/NumberDeserializers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,11 @@ protected final Boolean _parseBoolean(JsonParser p, DeserializationContext ctxt)
if (t == JsonToken.VALUE_STRING) {
String text = p.getText().trim();
// [databind#422]: Allow aliases
if ("true".equals(text) || "True".equals(text)) {
if ("true".equalsIgnoreCase(text)) {
_verifyStringForScalarCoercion(ctxt, text);
return Boolean.TRUE;
}
if ("false".equals(text) || "False".equals(text)) {
if ("false".equalsIgnoreCase(text)) {
_verifyStringForScalarCoercion(ctxt, text);
return Boolean.FALSE;
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/fasterxml/jackson/databind/deser/std/StdDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,10 @@ protected final boolean _parseBooleanPrimitive(JsonParser p, DeserializationCont
if (t == JsonToken.VALUE_STRING) {
String text = p.getText().trim();
// [databind#422]: Allow aliases
if ("true".equals(text) || "True".equals(text)) {
if ("true".equalsIgnoreCase(text)) {
return true;
}
if ("false".equals(text) || "False".equals(text)) {
if ("false".equalsIgnoreCase(text)) {
return false;
}
if (_isEmptyOrTextualNull(text)) {
Expand Down