Skip to content

fix test code #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2020
Merged

fix test code #2914

merged 1 commit into from
Nov 2, 2020

Conversation

jinwookh
Copy link
Contributor

@jinwookh jinwookh commented Nov 2, 2020

fixed 2 failing tests to success, where tests were in databind package.

@cowtowncoder
Copy link
Member

For a while I was puzzled since this obviously has not failed in Travis. Until I realized naming convention is off.... and these do fail from IDE.
Thanks!

@cowtowncoder cowtowncoder merged commit 15ceae9 into FasterXML:master Nov 2, 2020
cowtowncoder pushed a commit that referenced this pull request Nov 2, 2020
@jinwookh
Copy link
Contributor Author

jinwookh commented Nov 3, 2020

Just in curiosity... you're meaning that travis was ignoring these tests then?

@cowtowncoder
Copy link
Member

@jinwookh yes. Which is why I wasn't aware they were failing after refactoring of exception messages.

@jinwookh
Copy link
Contributor Author

jinwookh commented Nov 5, 2020

Got it. Thanks for the comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants