Skip to content

Add feature to inverse read/write access logic #4761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

Add feature to inverse read/write access logic #4761

merged 2 commits into from
Oct 28, 2024

Conversation

ggrebert
Copy link
Contributor

@ggrebert ggrebert commented Oct 22, 2024 •
edited
Loading

@cowtowncoder replacement of #2966

fix #2951

@ggrebert ggrebert mentioned this pull request Oct 22, 2024
Closed
@JooHyukKim
Copy link
Member

Did u mean to PR against master(version3) branch?
Asking this since it seems like something that can be applied to 2.19

@ggrebert
Copy link
Contributor Author

the target branch of this PR is 2.19

JooHyukKim
JooHyukKim reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@JooHyukKim JooHyukKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean

@cowtowncoder cowtowncoder added the cla-needed PR looks good (although may also require code review), but CLA needed from submitter label Oct 24, 2024
@cowtowncoder
Copy link
Member

Looks clean! One quick question @ggrebert: have we asked for (and received) a CLA earlier?
It's from

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf .

If not, we'd need it before merging (just once; good for any and all future contributions).
The usual way is to print it, fill & sign, scan/photo, email to cla at fasterxml dot com.
Once I get it I can merge the PR to get feature added in for 2.19!

Thank you again for contributing this feature; looking forward to merging it.

@ggrebert
Copy link
Contributor Author

CA signed and sended

@cowtowncoder
Copy link
Member

@ggrebert Almost there -- I asked for 2 minor changes for CLA and then we should be good. Apologies for the hassle, looking forward to getting this merged!

@ggrebert
Copy link
Contributor Author

@ggrebert Almost there -- I asked for 2 minor changes for CLA and then we should be good. Apologies for the hassle, looking forward to getting this merged!

done

@cowtowncoder cowtowncoder added cla-received PR already covered by CLA (optional label) and removed cla-needed PR looks good (although may also require code review), but CLA needed from submitter labels Oct 28, 2024
@cowtowncoder
Copy link
Member

CLA good!

cowtowncoder
cowtowncoder reviewed Oct 28, 2024
View reviewed changes
src/main/java/com/fasterxml/jackson/databind/introspect/POJOPropertyBuilder.java
@@ -946,6 +946,20 @@ public JsonProperty.Access removeNonVisible(boolean inferMutators,
if (acc == null) {
acc = JsonProperty.Access.AUTO;
}

// [databind#2951] add feature to inverse access logic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should actually be moved to occur within "findAccess()" -- I can change that

@cowtowncoder cowtowncoder merged commit 2aaea94 into FasterXML:2.19 Oct 28, 2024
8 checks passed
@cowtowncoder
Copy link
Member

Merged in 2.19 for 2.19.0. Thank you again @ggrebert !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JooHyukKim JooHyukKim JooHyukKim left review comments

@cowtowncoder cowtowncoder cowtowncoder approved these changes

Assignees
No one assigned
Labels
cla-received PR already covered by CLA (optional label)
Projects
None yet
Milestone
No milestone
3 participants
@ggrebert @JooHyukKim @cowtowncoder