Skip to content

Add failing test for #5049 #5061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 3, 2025
Merged

Add failing test for #5049 #5061

merged 6 commits into from
Apr 3, 2025

Conversation

cowtowncoder
Copy link
Member

No description provided.

@cowtowncoder cowtowncoder mentioned this pull request Apr 2, 2025
Closed
1 task
@cowtowncoder
Copy link
Member Author

Trying to debug through processing and it's confusing: somewhere down the line two parameters (initially fine as "a" and "b") get corrupted as ("b", "b") in CreatorCandidate.construct().
Have not been able to find any credible place where this happens... there's some redundancy in information collection which might be related but not clear which part.

@cowtowncoder cowtowncoder marked this pull request as ready for review April 3, 2025 04:40
@cowtowncoder cowtowncoder merged commit 7ff3e2d into 2.19 Apr 3, 2025
6 checks passed
@cowtowncoder cowtowncoder deleted the tatu/2.19/5049-record-read-only branch April 3, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cowtowncoder