Fix regression in ObjectNode.with()
#5099
Conversation
This fixes a regression that seems to have been introduced in d7adffa.
| @@ -87,7 +87,8 @@ public ObjectNode with(String exprOrProperty) { | |||
| .getClass().getName() + "`)"); | |||
| } | |||
| ObjectNode result = objectNode(); | |||
| return _put(exprOrProperty, result); | |||
| _put(exprOrProperty, result); | |||
| return result; | |||
There was a problem hiding this comment.
What does _put return to create regression ? Seems like it should work.
There was a problem hiding this comment.
I looked at original change and I think it's the difference between returning this (which _put() returns) vs ObjectNode being created that is to be returned here.
But I'd appreciate it if you can double-check @JooHyukKim .
There was a problem hiding this comment.
Yeah you are right on returing this vs created-ObjectNode
|
First of all, thank you for reporting this & providing patch! Good catch. Second: before merging the fix, I'd need a CLA (unless you have sent one in the part OR are covered by one of CCLAs (there are a few bigger corporations that have submitted ones)), from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf it only needs to be sent once, before the first merged PR. The usual way is to print it, fill & sign, scan/photo, email to |
Amazon is covered under an existing CCLA. |
Yes indeed. So this is under that CCLA -- we are good, thanks! ps. No wonder name sounded familiar -- I should have checked my emails first. Hope things are going well! |
cowtowncoder
changed the title
ObjectNode.with()
This fixes a regression that seems to have been introduced in d7adffa.