Perf+Feat: Removed unnecessary declarations in type propagator and type annotated more bytecode #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JuliaPoo
commented
Mar 3, 2023
JuliaPoo
commented
- The DSL has been modified to allow type annotations of output stack variables with input stack variables
- If the output stack variable is unmoved there is no need to type annotate it
- Type annotating the input stack variables isn't allowed because it doesn't make sense since type propagator isn't gonna check the types of the input stack variables
DSL now allows declaring the type of an output stack effect with the type of an input stack effect.
Updated DSL to not require type annotations for unmoved stack variables
Fidget-Spinner
approved these changes
Mar 3, 2023
|
Thanks! |
Fidget-Spinner
merged commit deec638
into
Fidget-Spinner:tier2_interpreter_no_separate_eval_no_tracer_contiguous_bbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.