This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Clean up api for serialization, fix bug with config fetching from webserver. #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ialization logic cleaner, fix bug where sometimes the connection would be closed while printing the config.
proppy
reviewed
Dec 13, 2016
|
|
||
| // We need a mutable char array here, otherwise a copy will be made. | ||
| void ReadFromJson(char* string); | ||
| static Config Deserialize(char* string); |
There was a problem hiding this comment.
nit: I wonder if you could just have a DeserializeTo(Config& config) w/ a ConfigJsonSerializer ctor that takes a string.
There was a problem hiding this comment.
Good suggestion, updated the signature.
* Fixed default config initialization. * Added Firething call to delete stored config.
|
Added a couple of other fixes I did from testing on friday. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where the webserver would close its connection while serving the config. The fix uses more memory due to extra copy but deeper debugging is required to determine whether the bug that is closing the connection is in ArduinoJson or in ESP8266WebServer's client object.
Also cleaned up interface for serialization by making it a class.