This repository was archived by the owner on Mar 17, 2025. It is now read-only.
Added remove() method. #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| String Firebase::sendRequestGetBody(const char* method, const String& path, const String& value) { | ||
| sendRequest(method, path, value); | ||
| if (_error.code() != 0) { | ||
| return ""; | ||
| } | ||
| // no _http.end() because of connection reuse. | ||
| return _http.getString(); |
There was a problem hiding this comment.
What do you think of splitting sendRequest and getBody functions? that way we can compose them more explicitly.
There was a problem hiding this comment.
Sounds good. We will continue discussion of higher level refactoring in the other PR.
| return getBody(); | ||
| } | ||
|
|
||
| bool Firebase::remove(const String& path) { |
There was a problem hiding this comment.
nit: I feel like we should return void here, to stay inline with the current way we have to check for error with error().
|
LGTM: just some nits. |
firebase: void return for send request and inline checkResponse
|
Tested on esp8266 feather huzzah. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soliving issue #18