This repository was archived by the owner on Mar 28, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(17): Add timeout to auto unlock recurring tasks #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28e82e6
to
dc63661
Compare
gagantrivedi
commented
Jan 6, 2025
gagantrivedi
commented
Jan 6, 2025
dc63661
to
cba7ead
Compare
gagantrivedi
commented
Jan 6, 2025
cba7ead
to
f0ac380
Compare
gagantrivedi
commented
Jan 6, 2025
task_processor/migrations/sql/0012_get_recurringtasks_to_process.sql
Outdated
Show resolved
Hide resolved
gagantrivedi
commented
Jan 6, 2025
dfd51cd
to
6e07161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few fairly minor comments / questions, but overall this looks excellent 👌
task_processor/migrations/sql/0012_get_recurringtasks_to_process.sql
Outdated
Show resolved
Hide resolved
tests/unit/task_processor/test_unit_task_processor_processor.py
Outdated
Show resolved
Hide resolved
ed052fa
to
d8a4c37
Compare
matthewelwell
approved these changes
Jan 8, 2025
tests/unit/task_processor/test_unit_task_processor_processor.py
Outdated
Show resolved
Hide resolved
gagantrivedi
commented
Jan 10, 2025
matthewelwell
approved these changes
Jan 13, 2025
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17 by picking up locked tasks for processing after a timeout.