Bug with Unicode

[wooorm]

> S = require('github-slugger');
[Function: BananaSlug]
> s = new S
BananaSlug { occurrences: {} }
> s.slug('I ♥ unicode')
'i-♥-unicode'

...but, GitHub slugs that to i--unicode.

Apparently, this used to work fine: github-slugger used to output i--unicode (compare the last Travis build with the one I just triggered).

It’s rather weird that this changed, I’ve got no idea why...

[wooorm]

This is introduced in [email protected] in mathiasbynens/emoji-regex@37d8faa, but exposed (as the old code was still used in the npm module) in [email protected] (and no, there was no [email protected] release).

Not sure whether ♥ is special though...

[Flet]

Should we lock down package.json to a specific version of emoji-regex for now?

[wooorm]

Yeah I think so!

[wooorm]

Oh, and do you have ideas for a fix? I’m thinking an overwrite for this character?

[Flet]

published as [email protected]