BUGFIX Catch exception if parent is not available #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcool
requested changes
Sep 28, 2021
fcool
approved these changes
Sep 28, 2021
kdambekalns
approved these changes
Oct 14, 2021
|
@kdambekalns Could you please also create a release for this patch? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If parent node is not found (e.g hidden node) a
NodeExceptionis thrown, which leads to a critial error. Instead of the error the exception needs to get caught and handled with anullresponse.This is bug caused by to the refactoring for Neos 7 upgrade, as the old
getParentmethod returnednulland didn't threw an exception:https://github.com/Flowpack/Flowpack.SimpleSearch.ContentRepositoryAdaptor/pull/39/files#diff-88acc12ebeb4d9a9a63c7ce0e321878e38ab59d0815716450d91e6acbb8762f0R251-R257
Fixes #42