Skip to content

Fix issues post move to Franklin.jl #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Fix issues post move to Franklin.jl #149

merged 2 commits into from
Oct 14, 2022

Conversation

darsnack
Copy link
Member

@darsnack darsnack commented Oct 14, 2022

Fixes the documentation link which broke after the port. It also adds missing assets for the blogs and tutorials. Closes #148. Closes #150.

@github-actions
Copy link

Once the build has completed, you can preview your PR at this URL: https://fluxml.ai/previews/PR149/

@darsnack darsnack changed the title Fix documentation link Fix issues post move to Franklin.jl Oct 14, 2022
@darsnack darsnack closed this Oct 14, 2022
@darsnack darsnack reopened this Oct 14, 2022
@github-actions
Copy link

Once the build has completed, you can preview your PR at this URL: https://fluxml.ai/previews/PR149/

@darsnack
Copy link
Member Author

@Saransh-cpp looks like the preview pre-path doesn't carry over to links in posts.

I also don't know why certain posts don't have the title page environment variable getting picked up. Seems like a Franklin issue (cc @tlienart)?

@tlienart
Copy link
Contributor

tlienart commented Oct 14, 2022

@darsnack can you point me to a page that has the issue you're talking about? or is it the items that get listed as Post 6 or Post 10? this is not an issue with Franklin but an issue with the function that does the listing of the posts; I'll have a look to see if I can fix it.

Separately, just had a quick look around (maybe this should go in a separate issue btw so we can go through it gradually), there seems to be a few issues with image links e.g. https://fluxml.ai/blogposts/2021-12-1-flux-numfocus/ looks like that's what this PR is about

@darsnack
Copy link
Member Author

I am merging this to resolve the asset and docs link issues. I'll open up a discussion specifically for the hfun issue.

@darsnack darsnack merged commit e7d446f into main Oct 14, 2022
@darsnack darsnack deleted the darsnack/fix-docs-link branch October 14, 2022 13:13
@darsnack
Copy link
Member Author

can you point me to a page that has the issue you're talking about? or is it the items that get listed as Post 6 or Post 10? this is not an issue with Franklin but an issue with the function that does the listing of the posts; I'll have a look to see if I can fix it.

Sorry, I should have been more specific. I opened up #151 to track this.

@Saransh-cpp
Copy link
Member

looks like the preview pre-path doesn't carry over to links in posts.

Hmm, I think this is happening because the navbar points to the folders available in the root directory -

<a class="nav-link" href="/getting_started/">Getting Started</a>
</li>
<li class="nav-item">
<a class="nav-link" href="https://fluxml.ai/Flux.jl/" target="_blank">Docs</a>
</li>
<li class="nav-item">
<a class="nav-link" href="/blog/">Blog</a>
</li>
<li class="nav-item">
<a class="nav-link" href="/tutorials/">Tutorials</a>
</li>
<li class="nav-item">
<a class="nav-link" href="https://fluxml.ai/Flux.jl/dev/ecosystem/">Ecosystem</a>
</li>
<li class="nav-item">
<a class="nav-link" href="/gsoc/">GSoC</a>

I'll try to fix this.

@darsnack
Copy link
Member Author

Not just the navbar but also image assets which are inserted like /assets/...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 error on Docs section Port over assets from old site
3 participants