Feature/laravel 5 4 compatibility blade compiler #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flushSectionsIfDoneRendering() method no longer in L5.4 Use flushStateIfDoneRendering() instead
getRawTags(), getContentTags(), getEscapedContentTags() methods are no longer in the L5.4 BladeCompiler.
Changed to just get the protected values from the class, no longer using the accessor methods.
On contentTags, and escapedTags use array_map('stripcslashes'). This matches the functionality in L5.3 BladeCompiler -- (see method getTags() in L5.3 Illuminate\View\Compilers\BladeCompiler).
Revised for backwards compatibility with L5.3, 5.2, 5.1
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first open source contribution, so hopefully I'm doing this correctly (not quite sure here).
This adds more compatibility with L5.4, and (hopefully) fixes the
Call to undefined method Illuminate\View\Factory::flushSectionsIfDoneRendering()issue.One change I made is in DbView class, line 77. Changed to check which version of Laravel is being used, and calls appropriate method based on the version.
The Second change I made was in DbBladeCompiler class, lines 20-22. It looks like in L5.4 the accessor methods were removed from the BladeCompiler, so I just grabbed the values straight from the protected attributes. The
contentTags, andescapedTagsin L5.3 were being called by getTags() method, which did anarray_map('stripcslashes'). I just called that on the attributes.