dont set DbView alias in service provider #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Flynsarmy can you make a new release after this? Thanks |
|
What's the point of the loader line if you're no longer doing anything with it? |
|
Does the alias still work now that you've removed all these lines? What version of Laravel are you on? |
|
yes tested, as long as user follows instructions in readme and added the alias to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was running into following error
Non-static method Flynsarmy\DbBladeCompiler\DbView::make() should not be called staticallySeems the advice of issue #30 + using dev-master instead of latest release fixes this