Fix crash in findFoundationDBClusterForNode when in global mode #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johscheuer
reviewed
May 10, 2025
Sure, I can do that. |
When the operator is execute with cluster-label-key-for-node-trigger flag in global mode it goes to crash loop, becasue the namespace is empty and in findFoundationDBClusterForNode a null pointer is passed to k8s-client Lister. We fix this issue by passing the variable only if namespace is not empty.
dig-whois
force-pushed
the
fix-null-ptr-issue-in-global-mode
branch
from
fc81ab9 to
d5b6e28
Compare
dig-whois
force-pushed
the
fix-null-ptr-issue-in-global-mode
branch
from
d5b6e28 to
4234989
Compare
johscheuer
reviewed
May 13, 2025
| Context("when finding fdb pods in a node", func() { | ||
| // All the nodes that are part of the cluster | ||
| var originalNodeList corev1.NodeList | ||
| // unrelatedNode is a node that does not holde a pod that is part of the cluster |
There was a problem hiding this comment.
Suggested change
| // unrelatedNode is a node that does not holde a pod that is part of the cluster | |
| // unrelatedNode is a node that does not hold a pod that is part of the cluster |
| err := k8sClient.Delete(context.Background(), unrelatedNode) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| }) | ||
| When("wathcing all namespaces", func() { |
There was a problem hiding this comment.
Suggested change
| When("wathcing all namespaces", func() { | |
| When("watching all namespaces", func() { |
…espaces or specific ones.
dig-whois
force-pushed
the
fix-null-ptr-issue-in-global-mode
branch
from
4234989 to
6f4016a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the operator is executed with
cluster-label-key-for-node-triggerflag in global mode it goes to crash loop, because the namespace is empty and inFoundationDBClusterReconciler.findFoundationDBClusterForNodea null pointer is passed to k8s-client Lister. We fix this issue by passing the variable only if namespace is not empty.Type of change
Please select one of the options below.
X Bug fix (non-breaking change which fixes an issue)
Discussion
N/A
Testing
We ran it in different environments.
Do we need to perform additional testing once this is merged, or perform in a larger testing environment?
No
Documentation
Did you update relevant documentation within this repository?
If this change is adding new functionality, do we need to describe it in our user manual?
If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?
If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?
Follow-up
Are there any follow-up issues that we should pursue in the future?
Does this introduce new defaults that we should re-evaluate in the future?