Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semantic-release configuration #80

Closed
markusguenther opened this issue Oct 13, 2019 · 1 comment
Closed

Fix semantic-release configuration #80

markusguenther opened this issue Oct 13, 2019 · 1 comment

Comments

@markusguenther
Copy link
Member

Describe the bug
The semantic release config seems to have an issue. The upgrade commit had a Breaking Change flag but this has not been detected and therefore the version number was wrong.

Expected behavior
Breaking commits and Breaking flags inside the description lead to a breaking release.
markusguenther added a commit that referenced this issue Oct 13, 2019
@markusguenther
Breaking: React version 14 peer dependency has been removed
1658628 
In a former commit the peer dependency has been removed but we had an issue
with semantic release that did not recognize the breaking change correctly.

This will be fixed later and this commit updates the changelog and keep the
versioning insync.

Sorry for the inconveniences.

Related: #80
@markusguenther
Copy link
Member Author

Has been fixed with version 4.2.1

@markusguenther markusguenther mentioned this issue Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@markusguenther