Pass nextProps into calcTheme #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass nextProps into calcTheme. Current implementation uses current props `theme` on update.
jdalpert
approved these changes
Oct 7, 2019
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to have been a refactor to avoid the deprecated method
componentWillReceiveProps. This decision lead tothis.propsbeing used withincalcThemeand its function calls.As a result, methods use outdated props including
themein my use case. Once the update is completed, the component never recalculates to use the latest props.Ex. Developer updates the theme of a global component when changing views. The theme never updates because when
theme !== nextProps.theme, all methods destructure fromthis.props. Thus resulting intheme(old) being used.This fix aims to provide the most up to date props when calculating theme #78
Fixes: #78