Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base test classes are missing from package builds #379

Closed
vworldat opened this issue Dec 13, 2024 · 1 comment
Closed

Base test classes are missing from package builds #379

vworldat opened this issue Dec 13, 2024 · 1 comment

Comments

@vworldat
Copy link
Contributor

As already commented by @JohannesTyra at 3f0adca#commitcomment-149925742 the change to include test/ in .gitattributes not only messes with the autoloader, but also removes critical classes like sfTestBaseTask or sfTester from all git exports and thus composer packaging.

I think the line should be changed to /test/ to only match the actual symfony1 tests that can be safely ignored.

@thePanz
Copy link
Member

thePanz commented Dec 14, 2024

@vworldat I checked on on of my SF1.5 projects, but was not able to reproduce the issue when running some of he SF1 actions.
Not sure if it is due to a different scenario, or the wrapping with SF5.4 I have in place.

Do you have a reproducible example we can test and replicate on the tests to avoid those breaking changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants