Fundraiser code quality and testing #322

Braqzen · 2022-12-11T21:05:47Z

Type of change

Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes

The following changes have been made:

Separated data_structures.sw into directory of libraries
Split contract abi into 2 abis: core and info (getters) for maintenance
Split tests/functions into core and info, similar changes to utils
Bumped SDK to 0.33.0 and changed Panics / Reverts to use the Sway error enums instead of generic messages
Added code to check that Sway events are logged properly
Any tests that were previously marked with #[ignore] are now tested
Changed deadline in tests to be slightly more flexible
- Instead of hardcoding a number we use the current block height plus an arbitrary number based on the testing setup

Related Issues

Closes #318
Closes #219

fundraiser/project/fundraiser-contract/src/data_structures/asset_info.sw

fundraiser/project/fundraiser-contract/src/data_structures/state.sw

fundraiser/project/fundraiser-contract/src/interface.sw

fundraiser/project/fundraiser-contract/src/main.sw

fundraiser/project/fundraiser-contract/tests/functions/core/cancel_campaign.rs

fundraiser/project/fundraiser-contract/src/interface.sw

fundraiser/project/fundraiser-contract/src/data_structures/campaign_info.sw

fundraiser/project/fundraiser-contract/tests/functions/core/create_campaign.rs

fundraiser/project/fundraiser-contract/tests/functions/core/pledge.rs

supiket

Looks great, though didn't look into the tests with a magnifying glass.

Some additional comments:

interface.sw
- create_campaign says that it reverts when asset is the BASE_ASSET, is that still so? There is no test for that.
- pledge is missing that it reverts when asset amount is 0

These comments are not for changed files but rather further changes:

Specification typos
- pledge_count() items 1 and 2 have "pledgd", suggesting to change them to "pledged"
- user_campaign_count() item 2 has a "." in the middle of the sentences, suggesting to remove that
Errors TargetReached and ContractNotInitialized are not used anywhere

fundraiser/project/fundraiser-contract/src/data_structures/pledge.sw

fundraiser/project/fundraiser-contract/src/main.sw

fundraiser/project/fundraiser-contract/tests/utils/interface/core.rs

Co-authored-by: Matt <[email protected]>

matt-user

lgtm

* chore: add version tag to deps (#361) (#362) * Fundraiser code quality and testing (#322) * Multisig-wallet ETH signature support (#272) * eth-account-abstraction; added initial predicate * eth-account-abstraction; updated predicate to use public key * eth-account-abstraction; added script for pub key derivation and updated predicate with derived pub key * eth-account-abstraction; swicthed to using addresses * eth-account-abstraction; basic ec_recover functionaliy * eth-account-abstraction; cleaned up * eth-account-abstraction; added panicking test * eth-account-abstraction; add eth_prefix util * eth-account-abstraction; added eip_191_hash util * eth-account-abstraction; added ec_recover_evm_address util * Added recover.sw and associated test for debugging ec recovery * Synced with master * Updated cargo.toml for linting * Updated cargo.toml for linting * Added test for debugging with sway script * Setup for EVM address * Renamed recover script * Setup for verifying address hashing in Sway * Setup testing ec_recover from known valid signature * Setup for testing Secretkey creation via different methods * Setup for testing signature creation methods * Cleaned up testing signature creation methods * Setup for working with correct values via sign_compact_recoverable * Updated reference/target values * Cleaned up; setup for recovery of evm address * Updated to forc 0.30 and fuels 0.28 * Updated to use SDK's sign_message * Added panicing test * Updated eip_191_format and added utils as dep * Added sha3 as dependency * Setup for testing inputs of hashing during eip-191 formatting * Setup for comparison of bit-shifted data * Updated to new compose & decompose functions * Setup for testing eip-191 formatting, with temp padded data * Updated encode_data docs * Setup for testing single signature, with EIP-191(padded) and Eth-prefix, recovery * Updated signing mechanism and refactored test utils * Single signature, with EIP-191 format and Eth-prefix, recovery * forc-fmt * fmt * Switched to contract to test updated count_approval function * Multi-sig style account abstracted signature recovery * Refactored utils * Resolved errors from forc updates * Updated constructor * Updated execute_transaction * Updated transfer * Removed is_owner * Updated transaction_hash * Updated nonce * Updated create_hash * Added account abstracted count_approvals functionality * Updated interface imports * Renamed to interface * Updated documentation * Refactored utils * Removed pub from count_approvals * Multi-Sig setup for basic account abstraction test * Updated forc and fuels versions * Refactor: transfer * Setup for basic full transfer test * Refactor: tests/utils/mod.rs and cleared up docs * Removed unused imports * Added abi calls * Added test_helpers * Added deps * Refactored encode_data * Setup full testing format * Added function testing * Added gets_transaction_hash test * Refactored create_hash * Removed unused imports and fixed signature variable definition * Refactored gets_transaction_hash * Removed eth-account-abstraction dir * Removed unused deps * Refactored multisig-wallet dir ahead of merge * CI; update forc * Updated in-code docs * Updated README * Refactored for contributing book code style compliance * Update multisig-wallet/project/multisig-contract/src/data_structures.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <[email protected]> * Fixed grammar * Refactored SignatueData and added field docs * Updated constructor docs * Refactored SignatureData within format_and_sign * Removed imports already contained within prelude * Refactored single imports * CI: Forc.toml * Docs: replaced Panics with Reverts * Refactored comments and removed unneeded comments * Reworder SignaturData docs * Renamed SignatureData fields * Renamed SignatureData => SignatureInfo * Renamed signatures_data => signatures and signature_data => signature_info * Swicthed to backticks * Ordered event fields * Refactored User docs * Added check in constructor for threshold <= sum of weights * recover_signer; use propagated error from ec_recover_address * Added link to EIP-191 and EIP-191 constants * Renamed encode_and_pack_signed_data and refactored eip_191_personal_sign_format * Added cancel_transaction * Refactored utils * Ethereum Prefix now uses Keccak256 * Updated ethereum_prefix docs * Refactored tests with utility parameters * Refactored revert module into alphabetical order * Added paths module * Added TODO regarding use of unsafe blocks * Added EIP-191 info to README * Added specification and sequence diagram * Added template tests for execute_transaction * Bumped versions and refactored utils * Refactored utils and added comment * Bump in line with repo * Removed redundent headings * Added suggested assertion to balance test * Update multisig-wallet/project/multisig-contract/tests/functions/cancel_transaction.rs Co-authored-by: Braqzen <[email protected]> * Reordered tests * Added suggestion to constructor test * Added should panic errors * Update multisig-wallet/project/multisig-contract/tests/functions/nonce.rs Co-authored-by: Braqzen <[email protected]> * Updated test assertions * Removed redundant transfer * Renamed constructor_users to defaul_users * Updated Bytes ToDos * Renamed contract binding type * Refactored * Renamed abi_calls to interface * Added testing for logs Co-authored-by: Matt <[email protected]> Co-authored-by: Braqzen <[email protected]> * Timelock Smart Contract (#338) * Remove an outdated comment from the Timelock contract * Bump repo (#364) * Contributing Book: Improve Testing Page (#368) * AMM utils & contract logs (#365) * Tic-Tac-Toe application (#157) * changed - to * refs #392 (#393) * Fix broken links in sway-applications NFT docs (#387) Co-authored-by: Cameron Carstens <[email protected]> --------- Co-authored-by: Matt <[email protected]> Co-authored-by: Braqzen <[email protected]> Co-authored-by: K1-R1 <[email protected]> Co-authored-by: Kaiser Sakhi <[email protected]> Co-authored-by: Bikem <[email protected]> Co-authored-by: Ruben Amar <[email protected]> Co-authored-by: haadfida <[email protected]> Co-authored-by: Michael Hamilton Paler <[email protected]> Co-authored-by: bitzoic <[email protected]>

* chore: add version tag to deps (#361) (#362) * Fundraiser code quality and testing (#322) * Multisig-wallet ETH signature support (#272) * eth-account-abstraction; added initial predicate * eth-account-abstraction; updated predicate to use public key * eth-account-abstraction; added script for pub key derivation and updated predicate with derived pub key * eth-account-abstraction; swicthed to using addresses * eth-account-abstraction; basic ec_recover functionaliy * eth-account-abstraction; cleaned up * eth-account-abstraction; added panicking test * eth-account-abstraction; add eth_prefix util * eth-account-abstraction; added eip_191_hash util * eth-account-abstraction; added ec_recover_evm_address util * Added recover.sw and associated test for debugging ec recovery * Synced with master * Updated cargo.toml for linting * Updated cargo.toml for linting * Added test for debugging with sway script * Setup for EVM address * Renamed recover script * Setup for verifying address hashing in Sway * Setup testing ec_recover from known valid signature * Setup for testing Secretkey creation via different methods * Setup for testing signature creation methods * Cleaned up testing signature creation methods * Setup for working with correct values via sign_compact_recoverable * Updated reference/target values * Cleaned up; setup for recovery of evm address * Updated to forc 0.30 and fuels 0.28 * Updated to use SDK's sign_message * Added panicing test * Updated eip_191_format and added utils as dep * Added sha3 as dependency * Setup for testing inputs of hashing during eip-191 formatting * Setup for comparison of bit-shifted data * Updated to new compose & decompose functions * Setup for testing eip-191 formatting, with temp padded data * Updated encode_data docs * Setup for testing single signature, with EIP-191(padded) and Eth-prefix, recovery * Updated signing mechanism and refactored test utils * Single signature, with EIP-191 format and Eth-prefix, recovery * forc-fmt * fmt * Switched to contract to test updated count_approval function * Multi-sig style account abstracted signature recovery * Refactored utils * Resolved errors from forc updates * Updated constructor * Updated execute_transaction * Updated transfer * Removed is_owner * Updated transaction_hash * Updated nonce * Updated create_hash * Added account abstracted count_approvals functionality * Updated interface imports * Renamed to interface * Updated documentation * Refactored utils * Removed pub from count_approvals * Multi-Sig setup for basic account abstraction test * Updated forc and fuels versions * Refactor: transfer * Setup for basic full transfer test * Refactor: tests/utils/mod.rs and cleared up docs * Removed unused imports * Added abi calls * Added test_helpers * Added deps * Refactored encode_data * Setup full testing format * Added function testing * Added gets_transaction_hash test * Refactored create_hash * Removed unused imports and fixed signature variable definition * Refactored gets_transaction_hash * Removed eth-account-abstraction dir * Removed unused deps * Refactored multisig-wallet dir ahead of merge * CI; update forc * Updated in-code docs * Updated README * Refactored for contributing book code style compliance * Update multisig-wallet/project/multisig-contract/src/data_structures.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <[email protected]> * Fixed grammar * Refactored SignatueData and added field docs * Updated constructor docs * Refactored SignatureData within format_and_sign * Removed imports already contained within prelude * Refactored single imports * CI: Forc.toml * Docs: replaced Panics with Reverts * Refactored comments and removed unneeded comments * Reworder SignaturData docs * Renamed SignatureData fields * Renamed SignatureData => SignatureInfo * Renamed signatures_data => signatures and signature_data => signature_info * Swicthed to backticks * Ordered event fields * Refactored User docs * Added check in constructor for threshold <= sum of weights * recover_signer; use propagated error from ec_recover_address * Added link to EIP-191 and EIP-191 constants * Renamed encode_and_pack_signed_data and refactored eip_191_personal_sign_format * Added cancel_transaction * Refactored utils * Ethereum Prefix now uses Keccak256 * Updated ethereum_prefix docs * Refactored tests with utility parameters * Refactored revert module into alphabetical order * Added paths module * Added TODO regarding use of unsafe blocks * Added EIP-191 info to README * Added specification and sequence diagram * Added template tests for execute_transaction * Bumped versions and refactored utils * Refactored utils and added comment * Bump in line with repo * Removed redundent headings * Added suggested assertion to balance test * Update multisig-wallet/project/multisig-contract/tests/functions/cancel_transaction.rs Co-authored-by: Braqzen <[email protected]> * Reordered tests * Added suggestion to constructor test * Added should panic errors * Update multisig-wallet/project/multisig-contract/tests/functions/nonce.rs Co-authored-by: Braqzen <[email protected]> * Updated test assertions * Removed redundant transfer * Renamed constructor_users to defaul_users * Updated Bytes ToDos * Renamed contract binding type * Refactored * Renamed abi_calls to interface * Added testing for logs Co-authored-by: Matt <[email protected]> Co-authored-by: Braqzen <[email protected]> * Timelock Smart Contract (#338) * Remove an outdated comment from the Timelock contract * Bump repo (#364) * Contributing Book: Improve Testing Page (#368) * AMM utils & contract logs (#365) * Tic-Tac-Toe application (#157) * changed - to * refs #392 (#393) * Fix broken links in sway-applications NFT docs (#387) Co-authored-by: Cameron Carstens <[email protected]> * Update add ignored tests and update to use LEAF and NODE * Update to use latest release of sway-libs * Resolve merge conflicts --------- Co-authored-by: Matt <[email protected]> Co-authored-by: Braqzen <[email protected]> Co-authored-by: K1-R1 <[email protected]> Co-authored-by: Kaiser Sakhi <[email protected]> Co-authored-by: Bikem <[email protected]> Co-authored-by: Ruben Amar <[email protected]> Co-authored-by: haadfida <[email protected]> Co-authored-by: Michael Hamilton Paler <[email protected]> Co-authored-by: bitzoic <[email protected]>

* chore: add version tag to deps (#361) (#362) * Fundraiser code quality and testing (#322) * Multisig-wallet ETH signature support (#272) * eth-account-abstraction; added initial predicate * eth-account-abstraction; updated predicate to use public key * eth-account-abstraction; added script for pub key derivation and updated predicate with derived pub key * eth-account-abstraction; swicthed to using addresses * eth-account-abstraction; basic ec_recover functionaliy * eth-account-abstraction; cleaned up * eth-account-abstraction; added panicking test * eth-account-abstraction; add eth_prefix util * eth-account-abstraction; added eip_191_hash util * eth-account-abstraction; added ec_recover_evm_address util * Added recover.sw and associated test for debugging ec recovery * Synced with master * Updated cargo.toml for linting * Updated cargo.toml for linting * Added test for debugging with sway script * Setup for EVM address * Renamed recover script * Setup for verifying address hashing in Sway * Setup testing ec_recover from known valid signature * Setup for testing Secretkey creation via different methods * Setup for testing signature creation methods * Cleaned up testing signature creation methods * Setup for working with correct values via sign_compact_recoverable * Updated reference/target values * Cleaned up; setup for recovery of evm address * Updated to forc 0.30 and fuels 0.28 * Updated to use SDK's sign_message * Added panicing test * Updated eip_191_format and added utils as dep * Added sha3 as dependency * Setup for testing inputs of hashing during eip-191 formatting * Setup for comparison of bit-shifted data * Updated to new compose & decompose functions * Setup for testing eip-191 formatting, with temp padded data * Updated encode_data docs * Setup for testing single signature, with EIP-191(padded) and Eth-prefix, recovery * Updated signing mechanism and refactored test utils * Single signature, with EIP-191 format and Eth-prefix, recovery * forc-fmt * fmt * Switched to contract to test updated count_approval function * Multi-sig style account abstracted signature recovery * Refactored utils * Resolved errors from forc updates * Updated constructor * Updated execute_transaction * Updated transfer * Removed is_owner * Updated transaction_hash * Updated nonce * Updated create_hash * Added account abstracted count_approvals functionality * Updated interface imports * Renamed to interface * Updated documentation * Refactored utils * Removed pub from count_approvals * Multi-Sig setup for basic account abstraction test * Updated forc and fuels versions * Refactor: transfer * Setup for basic full transfer test * Refactor: tests/utils/mod.rs and cleared up docs * Removed unused imports * Added abi calls * Added test_helpers * Added deps * Refactored encode_data * Setup full testing format * Added function testing * Added gets_transaction_hash test * Refactored create_hash * Removed unused imports and fixed signature variable definition * Refactored gets_transaction_hash * Removed eth-account-abstraction dir * Removed unused deps * Refactored multisig-wallet dir ahead of merge * CI; update forc * Updated in-code docs * Updated README * Refactored for contributing book code style compliance * Update multisig-wallet/project/multisig-contract/src/data_structures.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Matt <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/main.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/interface.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <[email protected]> * Update multisig-wallet/project/multisig-contract/src/utils.sw Co-authored-by: Braqzen <[email protected]> * Fixed grammar * Refactored SignatueData and added field docs * Updated constructor docs * Refactored SignatureData within format_and_sign * Removed imports already contained within prelude * Refactored single imports * CI: Forc.toml * Docs: replaced Panics with Reverts * Refactored comments and removed unneeded comments * Reworder SignaturData docs * Renamed SignatureData fields * Renamed SignatureData => SignatureInfo * Renamed signatures_data => signatures and signature_data => signature_info * Swicthed to backticks * Ordered event fields * Refactored User docs * Added check in constructor for threshold <= sum of weights * recover_signer; use propagated error from ec_recover_address * Added link to EIP-191 and EIP-191 constants * Renamed encode_and_pack_signed_data and refactored eip_191_personal_sign_format * Added cancel_transaction * Refactored utils * Ethereum Prefix now uses Keccak256 * Updated ethereum_prefix docs * Refactored tests with utility parameters * Refactored revert module into alphabetical order * Added paths module * Added TODO regarding use of unsafe blocks * Added EIP-191 info to README * Added specification and sequence diagram * Added template tests for execute_transaction * Bumped versions and refactored utils * Refactored utils and added comment * Bump in line with repo * Removed redundent headings * Added suggested assertion to balance test * Update multisig-wallet/project/multisig-contract/tests/functions/cancel_transaction.rs Co-authored-by: Braqzen <[email protected]> * Reordered tests * Added suggestion to constructor test * Added should panic errors * Update multisig-wallet/project/multisig-contract/tests/functions/nonce.rs Co-authored-by: Braqzen <[email protected]> * Updated test assertions * Removed redundant transfer * Renamed constructor_users to defaul_users * Updated Bytes ToDos * Renamed contract binding type * Refactored * Renamed abi_calls to interface * Added testing for logs Co-authored-by: Matt <[email protected]> Co-authored-by: Braqzen <[email protected]> * Timelock Smart Contract (#338) * Remove an outdated comment from the Timelock contract * Bump repo (#364) * Contributing Book: Improve Testing Page (#368) * AMM utils & contract logs (#365) * Tic-Tac-Toe application (#157) * changed - to * refs #392 (#393) * Fix broken links in sway-applications NFT docs (#387) Co-authored-by: Cameron Carstens <[email protected]> * Pin `forc` and `fuel-core` versions in `fuel-toolchain.toml` (#377) * Fix CI (#406) * CI test * `cd` before `forc` commands * AMM correct versions * Removed StorageMap (#459) * OTC: unnecessary pub keyword * Fix build.sh devops script * AMM: Remove `ExpectedZeroAmount` error and relevant test (#402) * Restructure applications in preparation for user interfaces (#409) * New devops script to bump the fuel-toolchain.toml (#467) * Scaffolding tool for frontends (#394) * Factor out apps in .devops scripts into a single location * remove `Forc.toml` (#488) * update path (#490) * fix typo (#492) * UI scaffold: move `hooks` and `utils` into `src` (#496) * UI scaffold: Convert `echo`s to `printf`s (#497) * remove fuels prelude global imports (#501) * AMM: test emitted logs (#502) * Bump: AMM (#500) * TicTacToe: remove `identity` function from tests * TicTacToe: change `fuels::prelude::*` to be explicit * Fundraiser: change `fuels::prelude::*` to be explicit * Bump: OTC (#521) * F-NFT: Fix readme path link to specification * OTC Swap Predicate: Remove transaction building workaround (#544) * DAO: Split the abi into core and info * Bump: Oracle * Fix `.devops/bump_toolchain.sh` (#508) * Workaround: Merge Multisig into master * Oracle: test emitted logs * .devops script to format sway and rust code * F-NFT: Split the abi into core and info (#545) * bumped ci (#558) * English Auction: Split the abi into core and info * Name-Registry: Split the abi into core and info * Airdrop: test emitted logs (#524) * NFT: test emitted logs (#525) * DAO: test emitted logs (#522) * Escrow: test emitted logs (#523) * Bump: Airdrop (#516) * Airdrop: Split the abi into core and info (#540) * Bump: Escrow (#513) * Add information about the fuel-toolchain.toml files (#514) * Resolve merge conflicts * Remove merge conflict resolutions * Even MORE merge conflict resolutions --------- Co-authored-by: Matt <[email protected]> Co-authored-by: Braqzen <[email protected]> Co-authored-by: K1-R1 <[email protected]> Co-authored-by: Kaiser Sakhi <[email protected]> Co-authored-by: Bikem <[email protected]> Co-authored-by: Ruben Amar <[email protected]> Co-authored-by: haadfida <[email protected]> Co-authored-by: Michael Hamilton Paler <[email protected]> Co-authored-by: Kirito <[email protected]> Co-authored-by: Tarun Samanta <[email protected]> Co-authored-by: GeckoSplat <[email protected]> Co-authored-by: bitzoic <[email protected]>

Restructuring, completing tests, WIP

fd49282

Braqzen added Improvement Enhancing a feature that already exists App: Fundraiser Label used to filter for the app issue labels Dec 11, 2022

Braqzen self-assigned this Dec 11, 2022

Braqzen added 6 commits December 12, 2022 10:13

Events failing tests?

eb3086b

Tested events

6bfc157

Formatting main.sw

8f36c26

Data structures directory and AssetInfo refactor

40ff0c3

Wrapped pledged in Option

faa777f

Wrapped CampaignInfo in Option

43ff620

Braqzen mentioned this pull request Dec 13, 2022

Finish testing the Fundraiser #219

Closed

Braqzen added 2 commits December 13, 2022 12:58

Wrapped campaign in option

80676ca

Renamed test structs

4422ac4

Braqzen changed the title ~~Simplify the Fundraiser~~ Fundraiser code quality and testing Dec 14, 2022

Braqzen and others added 6 commits December 14, 2022 20:38

Updated interface documentation

7ae9607

Merge branch 'master' into braqzen-318

db82abc

Alphabetical order of state variants

b2a23c2

Ordered interface and implementation

9481bc9

Removed parameter from AssetInfo

f0fa0cd

Changed assertion to use matches macro

f2dd585

Braqzen force-pushed the braqzen-318 branch from 50553d3 to f2dd585 Compare December 15, 2022 11:35

CI new line

f4666c7

Braqzen mentioned this pull request Dec 21, 2022

Bump Repo #325

Merged

Resolved merge conflicts

8a363a0

Braqzen marked this pull request as ready for review December 23, 2022 17:33

Braqzen requested a review from simonr0204 as a code owner December 23, 2022 17:33

Braqzen requested a review from a team December 23, 2022 17:33

simonr0204 reviewed Dec 24, 2022

View reviewed changes

fundraiser/project/fundraiser-contract/src/data_structures/asset_info.sw Show resolved Hide resolved

matt-user suggested changes Jan 2, 2023

View reviewed changes

Braqzen mentioned this pull request Jan 6, 2023

Create an Application Template #341

Closed

supiket reviewed Jan 9, 2023

View reviewed changes

fundraiser/project/fundraiser-contract/src/data_structures/pledge.sw Outdated Show resolved Hide resolved

fundraiser/project/fundraiser-contract/src/main.sw Outdated Show resolved Hide resolved

fundraiser/project/fundraiser-contract/tests/utils/interface/core.rs Show resolved Hide resolved

Braqzen and others added 10 commits January 16, 2023 12:48

State -> CampaignState

6fd8a03

Renamed function

6cca43d

Spec typos

68584bf

Removed unused errors

b833ba9

Renamed field

502d98a

id -> campaign_id

5cafc82

Fixed tests based on renaming

0432d0f

Update fundraiser/project/fundraiser-contract/src/interface.sw

6bb0bda

Co-authored-by: Matt <[email protected]>

Typo

042659f

Removed old revert documentation

b130787

Braqzen requested a review from matt-user January 16, 2023 17:31

Merge branch 'master' into braqzen-318

e5c988f

Braqzen enabled auto-merge (squash) January 16, 2023 17:32

Braqzen requested a review from a team January 17, 2023 15:30

Braqzen added 3 commits January 17, 2023 18:39

Merge branch 'master' into braqzen-318

a07931a

Merge branch 'master' into braqzen-318

639dbe1

Merge branch 'master' into braqzen-318

36f0c67

matt-user approved these changes Jan 18, 2023

View reviewed changes

Braqzen merged commit 1f4d46b into master Jan 18, 2023

Braqzen deleted the braqzen-318 branch January 18, 2023 23:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fundraiser code quality and testing #322

Fundraiser code quality and testing #322

Uh oh!

Braqzen commented Dec 11, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supiket left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matt-user left a comment

Uh oh!

Uh oh!

Fundraiser code quality and testing #322

Fundraiser code quality and testing #322

Uh oh!

Conversation

Braqzen commented Dec 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Changes

Related Issues

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

supiket left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matt-user left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Braqzen commented Dec 11, 2022 •

edited

Loading