-
Notifications
You must be signed in to change notification settings - Fork 5
fix: gp and feat: Commitizen and pre-commit hooks #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll mark this ready when ready. A new label for that too? |
Yeah |
Created that with a green colour. I am testing pre-commit hooks, those are the most important part. It has a formatter named |
Gitpod is slowing down. |
Damn, for 21f4dbf, I almost rage-quitted! Commitizen expected perfection dude! It WORKS!!! |
It's better for people to use the CLI method to commit. |
That is Commitizen. Works, right? |
I'm testing this. BREAKING CHANGE:
Gitpod fails though |
Yeah I have encountered this. The image isn't updated properly though(still unmerged). I think I might be getting onto an idea of sorts, like maybe I'll try doing what the Gitpod people tell us, install Tk-dev from the APT repos. I will try that and report back. Need some free time. |
So that I can start a proper env
Damn, Gitpod is so hard! Looks like we need a custom Dockerfile, I have asked the Gitpod folks on how to make that. |
added nvm code. This does work
That's a problem since I discovered, init changes for pip persist ONLY in $HOME, not /workspace.
Done a bunch of fixes. |
I'm confused about the Gitpod part, I will fix that soon. For now, everything works perfectly. Maybe soon, I will try using shell scripts for automation. What's your opinion? |
We are getting some help soon! gitpod-io/workspace-images#609 (comment) |
That's where we'll be hosting our scripts soon.
I added isort. Don't take me wrong and no offense, we do good work but this was how it looked before isort: # TimerX v0.2 by sumeshir26
# IMPORTS
ver = "0.9"
from time import sleep
from tkinter import TclError, ttk, Tk, PhotoImage, Frame, StringVar
import tkinter
from tkinter.constants import LEFT
from playsound import playsound
from threading import Thread
from platform import system
import os
from utils import *
import webbrowser
"""
# Disabled by default due to module unavailability on Linux
from BlurWindow.blurWindow import GlobalBlur, blur
"""
import darkdetect
from tkinter.messagebox import showinfo This was how it looked after: # TimerX v0.2 by sumeshir26
# IMPORTS
ver = "0.9"
import os
import tkinter
import webbrowser
from platform import system
from threading import Thread
from time import sleep
from tkinter import Frame, PhotoImage, StringVar, TclError, Tk, ttk
from tkinter.constants import LEFT
from playsound import playsound
from utils import *
"""
# Disabled by default due to module unavailability on Linux
from BlurWindow.blurWindow import GlobalBlur, blur
"""
from tkinter.messagebox import showinfo
import darkdetect That seems neat right? Also, I need to stop speed typing since I messed up the commit message lol. |
I like that way it clarified single imports first then the submodules were added. Neatness 100x%. @not-nef from now, we'll follow the Commitizen way of making commits. It's better in a good way. |
what |
Shocked? I don't understand. This is an easier way of handling Git and version control. Instead of uhh, so its just another was of writing commit messages right? is there a guide for that? |
I'll try this for Gitpod: |
We are ready for merging! Thanks a lot @axonasif for hosting our image on Docker Hub! If it's costing you, do tell us, we'll try having it on the repo. |
I'll just clean up and we'll be good to go. |
You're welcome, glad to know it works!
I'm new to using dockerhub, does it really cost the dockerhub repo-owner for pulls by other people? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM🎉
Also removed some private PATHs, changed some `init:`s in the Gitpod Config. Ready for merge _completely_!
Also @sumeshir26 please remember to remove private things like your PC path and etc. I have removed one of them from the |
idk, but when I was about to host my version of the same Dockerfile, it asked me to pay. Maybe it's for server maintenance. |
@not-nef need your opinion too! What do you think of Commitizen conventional commit schema? They even have other ones, so if you like another one better than this, I can change it later. |
PLEASEEEEE!
Merge? @not-nef your ideas! |
Waiting on @not-nef's review before merging |
I'll merge? |
ig |
An enhancement to commit writing and fixing Gitpod. I'd like to make a new label for Gitpod for PRs that add extra Gitpod functionality.
NOT READY YETReady!