Use the proper HLSL quad wave intrinsics in the SPD's quad reduction.… #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This will align HLSL with GLSL paths. Most drivers don't care about this change and optimize it anyway but some mobile drivers seem to benefit from it.
|
Thank you for bringing this to our attention. The change has been made locally and will be pushed out with the next update. Please keep this pull request open for the time being and we will close it when we bring the fix in. |
lzlrd
added a commit
to lzlrd/dlssg-to-fsr3
that referenced
this pull request
May 22, 2024
This updates to FSR3 3.0.4 and includes the following patches: - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#12 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#23 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#56 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#57
lzlrd
added a commit
to lzlrd/dlssg-to-fsr3
that referenced
this pull request
May 22, 2024
This updates to FSR3 3.0.4 and includes the following patches: - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#12 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#23 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#56 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#57 ...as well as adding additional exports required here.
lzlrd
added a commit
to lzlrd/dlssg-to-fsr3
that referenced
this pull request
Jun 2, 2024
This updates to FSR3 3.0.4 and includes the following patches: - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#12 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#23 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#56 - GPUOpen-LibrariesAndSDKs/FidelityFX-SDK#57 ...as well as adding additional exports required here.
|
I think I can now close this PR. The change appears to be in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… This will align HLSL with GLSL paths.
Most drivers don't care about this change and optimize it anyway but some mobile drivers seem to benefit from it.