Skip to content

no support for VkBufferUsageFlags2CreateInfoKHR #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qbojj opened this issue Feb 27, 2024 · 2 comments
Closed

no support for VkBufferUsageFlags2CreateInfoKHR #411

qbojj opened this issue Feb 27, 2024 · 2 comments
Labels
feature Adding new feature next release To be done as soon as possible

Comments

@qbojj
Copy link
Contributor

qbojj commented Feb 27, 2024

Vma in many places (e.g vmaCreateBuffer) assumes that usage information is in p*CreateInfo->usage but with VK_KHR_maintenance5 it can be in VkBufferUsageFlags2CreateInfoKHR in the pNext chain
adam-sawicki-a added a commit that referenced this issue Feb 27, 2024
@adam-sawicki-a
Added support for VK_KHR_maintenance5 extension
19b940e 
Added VMA_ALLOCATOR_CREATE_KHR_MAINTENANCE5_BIT flag.
See #411 - thanks @qbojj
@adam-sawicki-a
Copy link
Contributor

Thank you for reporting this. I agree this is a deficiency that should be fixed ASAP. I added support for this. Please let me know if it looks good to you.

@adam-sawicki-a adam-sawicki-a added feature Adding new feature next release To be done as soon as possible labels Feb 27, 2024
@qbojj
Copy link
Contributor Author

qbojj commented Feb 27, 2024

LGTM

@qbojj qbojj closed this as completed Feb 27, 2024
@mjrister mjrister mentioned this issue May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Adding new feature next release To be done as soon as possible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adam-sawicki-a @qbojj