Skip to content

gmt.conf.rst: make table for listing terms #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

gmt.conf.rst: make table for listing terms #3627

wants to merge 1 commit into from

Conversation

anbj
Copy link
Contributor

@anbj anbj commented Jul 8, 2020

gmt.conf.rst: make table for listing terms

@seisman
Copy link
Member

seisman commented Jul 8, 2020

@anbj Thanks for making it look better.

You're using a "grid table" syntax to list the terms. It's OK, but we (at least myself) usually find it difficult to maintain/edit/update a grid table. Thus we (again, at least myself) prefer to use a much simpler table syntax.

Please see https://docs.generic-mapping-tools.org/latest/rst-cheatsheet.html#simple-table for an example of the "simple table" syntax (right column for the raw code, left column for preview).

@anbj
Copy link
Contributor Author

anbj commented Jul 8, 2020

@seisman Great, thanks for the tip! I’ll do it that way (if not anyone beats me to it) when I get back from vacation.

@seisman seisman changed the base branch from 6.1 to master July 10, 2020 20:26
@seisman
Copy link
Member

seisman commented Jul 10, 2020

Hi @anbj, we know that it's frustrating to switch between master and 6.1 branches when submitting a PR. After some discussion, we have improved our workflow to make it more friendly to contributors (and also to us).

All new branches should be created from the master branch, and PRs should be merged into master branch, too. If the changes are critical for GMT 6.1.x release, then we will backport the changes into 6.1 branch, and the fix will be available in the next patch release.

So I've changed the base branch of this PR to master branch. It doesn't affect your branch and this PR.

@anbj
Copy link
Contributor Author

anbj commented Jul 10, 2020

Great @seisman, thanks for the info. I’ll close this PR and make a new one with the simple table syntax when I have the opportunity.

@anbj anbj closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants