Skip to content

A variety of rst fixes plus a few code standardizations #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

PaulWessel
Copy link
Member

Most of this PR is just improving the RST docs but also fixing mistakes as I find them (typos, formatting error etc). I ran across a few issues that warranted a code update:

  1. psmeca and pscoupe had option syntax that ended in optional f and u. I changed this to +f and +u (backwards compatible)
  2. mgd77list had -C for distance calculations, changed to -j as in other modules.
  3. talwani3d did not allow users to set a latitude for geoid calculations (lie talwani2d does).
  4. grdrotator had a trailing + instead of +n in -T.

Not sure why but after this only 26 (instead of 27) tests fail for me on OS X.

Most of this PR is just improving the RST docs but also fixing mistakes as I find them (typos, formatting error etc).  I ran across a few issues that warranted a code update:
psmeca and pscoupe had optino syntax that ended in optional f and u.  I changed this to +f and +u (backwards compatible)
mgd77list had -C for distance calculations, changed to -j
talwani3d did not allow user to set latitude for geoid calculations
@PaulWessel PaulWessel requested a review from a team March 25, 2019 06:11
Copy link
Contributor

@remkos remkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@remkos remkos merged commit d9cbd78 into master Mar 25, 2019
@remkos remkos deleted the morefixes branch March 25, 2019 09:48
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
…info (GenericMappingTools#574)

Also renamed 'fname' argument to 'table'
since `info` supports both file name inputs
and pandas.DataFrame tables now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants