Skip to content

Drop support of old versions and removed deprecated codes for v0.16.0 #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
7 tasks done
seisman opened this issue Apr 9, 2025 · 1 comment
Closed
7 tasks done
Labels
maintenance Boring but important stuff for the core devs
Milestone

Comments

@seisman
Copy link
Member

seisman commented Apr 9, 2025

Following our quarterly release plan, we expect to release v0.16.0 in June 2025. As per the SPEC0 policy, we should

As for optional dependencies, we agreed to "maintain support for optional dependencies for at least 1 year after their initial release.". So we also need to decide if we want to drop these optional dependencies:

Here are the related TODO comments:

pygmt/clib/conversion.py:        # TODO(pandas>=2.1): Remove the workaround for pandas<2.1.
pygmt/tests/test_clib_to_numpy.py:                # TODO(pandas>=2.1): Remove the skipif marker for pandas<2.1.
pygmt/tests/test_clib_to_numpy.py:        # TODO(pandas>=2.1): Simplify the if-else statement.
pygmt/clib/session.py:        # TODO(PyGMT>=0.16.0): Remove the "*args" parameter and related codes.
pygmt/tests/test_clib_virtualfile_from_vectors.py:# TODO(PyGMT>=0.16.0): Remove this test in PyGMT v0.16.0 in which the "*args" parameter
pygmt/datasets/tile_map.py:    # TODO(contextily>=1.5.0): Remove the check for the 'zoom_adjust' parameter.
pygmt/helpers/tempfile.py:            # TODO(GeoPandas>=1.0): Remove the workaround for GeoPandas < 1.
pygmt/tests/test_clib_to_numpy.py:            # TODO(pyarrow>=16): Remove the skipif marker for pyarrow<16.
@seisman seisman added this to the 0.16.0 milestone Apr 9, 2025
@seisman seisman added help wanted Helping hands are appreciated maintenance Boring but important stuff for the core devs labels Apr 9, 2025
@weiji14
Copy link
Member

weiji14 commented Apr 14, 2025

Sounds fair, this would allow us to remove the note here:

pygmt/pygmt/src/tilemap.py

Lines 106 to 107 in fd92fb7

.. note::
The ``zoom_adjust`` parameter requires ``contextily>=1.5.0``.

Agree. The PR at #3639 is currently failing with an AttributeError: module 'fiona' has no attribute 'path' error, which I think should be resolved with geopandas>1.0 that switched to pyogrio as the default backend engine.

Yep, this means we won't need to add pytest.mark.skipif as mentioned at #3639 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

No branches or pull requests

2 participants