Skip to content

Bump minimum supported version to geopandas>=1.0 #3908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2025
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 14, 2025

Description of proposed changes

Bumps minimum supported GeoPandas version to 1.0 in the pyproject.toml and environment.yml files.

Also removes workaround for geopandas v0.x compatibility added in #3247.

Xref #3456, addresses #3903

Preview:

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

weiji14 added 4 commits April 14, 2025 15:11
Bumps minimum supported GeoPandas version
to 1.0 in the pyproject.toml and environment.yml files.
Xref #3456
Workaround added in #3247 for geopandas v0.x and v1.x compatibility.
@weiji14 weiji14 added the deprecation Deprecating a feature label Apr 14, 2025
@weiji14 weiji14 self-assigned this Apr 14, 2025
@weiji14 weiji14 added this to the 0.16.0 milestone Apr 14, 2025
@weiji14 weiji14 marked this pull request as ready for review April 14, 2025 04:24
@seisman
Copy link
Member

seisman commented Apr 14, 2025

Also need to fix the following lines:

optional-packages: ' contextily geopandas<1 ipython pyarrow-core rioxarray sphinx-gallery'

optional-packages: ' contextily geopandas>=1.0 ipython pyarrow-core rioxarray sphinx-gallery'

The CI job pass likely because they'res using the cached enviroments.

Edit: I've deleted all GitHub Actions caches using the command gh cache delete --all.

@weiji14 weiji14 merged commit 662f97e into main Apr 14, 2025
23 checks passed
@weiji14 weiji14 deleted the geopandas-1.0 branch April 14, 2025 23:37
weiji14 added a commit that referenced this pull request Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants