Skip to content

Migrate test_contour to use dvc #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 30, 2021
Merged

Migrate test_contour to use dvc #1146

merged 7 commits into from
Mar 30, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

As discussed in #1131, this PR moves the reference figures in fig.contour to use dvc.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

As discussed in #1131, this PR moves the reference figures in fig.contour to use dvc.
@michaelgrund michaelgrund added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Mar 29, 2021
@michaelgrund michaelgrund marked this pull request as draft March 29, 2021 16:20
@michaelgrund michaelgrund marked this pull request as ready for review March 29, 2021 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_contour_from_file.png
added pygmt/tests/baseline/test_contour_matrix.png
added pygmt/tests/baseline/test_contour_vec.png

Image diff(s)

  • pygmt/tests/baseline/test_contour_from_file.png

  • pygmt/tests/baseline/test_contour_matrix.png

  • pygmt/tests/baseline/test_contour_vec.png

Report last updated at commit 6083161

@seisman seisman added this to the 0.4.0 milestone Mar 30, 2021
@michaelgrund michaelgrund changed the title WIP: Migrate test_contour to use dvc Migrate test_contour to use dvc Mar 30, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@seisman seisman merged commit 7700ea1 into master Mar 30, 2021
@seisman seisman deleted the test-contour-dvc branch March 30, 2021 06:56
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants