Skip to content

Migrate Figure.legend tests to use dvc #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2021
Merged

Migrate Figure.legend tests to use dvc #1166

merged 2 commits into from
Apr 3, 2021

Conversation

willschlitzer
Copy link
Contributor

Per #1131, this moves the reference figures in fig.legend to use dvc.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 3, 2021
@willschlitzer willschlitzer added this to the 0.4.0 milestone Apr 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2021

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_legend_default_position.png
added pygmt/tests/baseline/test_legend_position.png
added pygmt/tests/baseline/test_legend_specfile.png

Image diff(s)

  • pygmt/tests/baseline/test_legend_default_position.png

  • pygmt/tests/baseline/test_legend_position.png

  • pygmt/tests/baseline/test_legend_specfile.png

Report last updated at commit 2443f9e

@willschlitzer
Copy link
Contributor Author

@GenericMappingTools/python Any idea why I'm getting a deployment error on this pull request?

@michaelgrund
Copy link
Member

@GenericMappingTools/python Any idea why I'm getting a deployment error on this pull request?

No idea, the other PR's work quite well.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GenericMappingTools/python Any idea why I'm getting a deployment error on this pull request?

No idea, the other PR's work quite well.

Could be an intermittent issue, try merging in the master branch to trigger a new deployment to see if it's ok. Anyways, this PR looks good to merge.

Copy link
Member

@michaelgrund michaelgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!

@seisman seisman changed the title Migrate fig.legend tests to use dvc Migrate Figure.legend tests to use dvc Apr 3, 2021
@seisman seisman merged commit 7be772b into master Apr 3, 2021
@seisman seisman deleted the test-legend-dvc branch April 3, 2021 15:05
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants