-
Notifications
You must be signed in to change notification settings - Fork 229
Migrate Figure.legend tests to use dvc #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)
Report last updated at commit 2443f9e |
@GenericMappingTools/python Any idea why I'm getting a deployment error on this pull request? |
No idea, the other PR's work quite well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GenericMappingTools/python Any idea why I'm getting a deployment error on this pull request?
No idea, the other PR's work quite well.
Could be an intermittent issue, try merging in the master branch to trigger a new deployment to see if it's ok. Anyways, this PR looks good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge!
Per #1131, this moves the reference figures in
fig.legend
to usedvc
.Fixes #
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version