-
Notifications
You must be signed in to change notification settings - Fork 229
Complete documentation for grdtrack #1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Starting to properly document all major parameters for `grdtrack` as per upstream GMT docs at https://docs.generic-mapping-tools.org/6.1/grdtrack. Begin by adding long aliases for resampling (A), cross_profile (C), profile (E), and common aliases region (R) and distcalc (j).
What is the convention for including separators in the aliases? Here it seems as if partial words are concatenated without a separator (e.g., distcalc) while full words are separated with an underscore (e.g. cross_profile). But at least one of the planned aliases for the common options (skiprows) is two full words concatenated without a separator #48 (comment). In a quick search I did not find any established guidelines for this topic; it would be helpful to have this documented given all the conversations and development about long options and aliases happening. |
There isn't a policy yet I think, so how about this. Use an underscore to separate words bridged by vowels (aeiou), e.g. no_skip, z_only, etc. Don't use underscore for others, e.g. distcalc, crossprofile (I'll change this) and coltypes. What do you think? |
Very nice! |
As per GenericMappingTools#1190 (comment). Plus re-wrap some paragraphs to 79 characters.
As per GenericMappingTools#1190 (comment). Plus re-wrap some paragraphs to 79 characters.
For reference, here is what GMT.jl uses: |
83e509e
to
b4cc56a
Compare
b4cc56a
to
4d58d0f
Compare
Co-Authored-By: Meghan Jones <[email protected]>
Finish up aliasing parameters for `grdtrack` as per upstream GMT docs at https://docs.generic-mapping-tools.org/6.1/grdtrack. Begin by adding long aliases for resample (A), crossprofile (C), profile (E), and common aliases region (R), verbose (V), coltypes (f), distcalc (j), and interpolation (n). * Alias no_skip (N) and z_only (Z) for grdtrack * Alias dfile (D) for grdtrack * Alias critical (F) for grdtrack * Alias stack (S) for grdtrack * Alias radius (T) for grdtrack * Alias incols (i) for grdtrack Co-authored-by: Meghan Jones <[email protected]>
Description of proposed changes
Finish up aliasing parameters for
grdtrack
, improving the documentattion to be better than what we currently have at https://www.pygmt.org/v0.3.1/api/generated/pygmt.grdtrack.html! For reference, upstream GMT docs is at https://docs.generic-mapping-tools.org/6.1/grdtrack.html and https://github.com/GenericMappingTools/gmt/blame/master/doc/rst/source/grdtrack.rst.Preview at https://pygmt-git-complete-docs-grdtrack-gmt.vercel.app/api/generated/pygmt.grdtrack.html
TODO:
Arguments/Aliases to document (see also https://www.generic-mapping-tools.org/GMT.jl/dev/#GMT.grdtrack). New aliases are highlighted in bold:
Finalizes #307. Note: Merge this PR after #1189.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version