-
Notifications
You must be signed in to change notification settings - Fork 229
Add a list of external PyGMT resources #1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
367cc93
to
44ee95a
Compare
Thanks for submitting this PR - the resources are great! I would prefer that these resources go under a different section than 'getting started'. One option would be to have a new "Examples" section that could include the "Gallery" and "External examples". I think that the external tutorials could be included in that section for now, but long term could go into the redesigned tutorial sidebar (#1191). Also, I prefer "External examples" or something else over "User Contributed Resources" to make it more clear PyGMT is not trying to take ownership of these resources and is just providing links. I think this could make people who aren't PyGMT developers more likely to include links to their PyGMT projects in the page. |
I agree with @meghanrjones , would also use something like "External examples". |
Good suggestion. I renamed the page to "External Resources" and moved it to the "Examples" section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I just have one small comment about the instructions for adding an example.
Co-authored-by: Meghan Jones <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Looks great~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Ping @liamtoney and @weiji14 as their contributions are listed. |
Co-authored-by: Wei Ji <[email protected]>
Co-authored-by: Meghan Jones <[email protected]> Co-authored-by: Wei Ji <[email protected]>
Description of proposed changes
Fixes #1059
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version