Skip to content

Update the inset gallery example #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 28, 2021
Merged

Update the inset gallery example #1287

merged 9 commits into from
May 28, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Increase the margin pen size of the inset box since after updating to GMT 6.2.0rc1 it appears to be too thin.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added documentation Improvements or additions to documentation maintenance Boring but important stuff for the core devs labels May 23, 2021
@michaelgrund michaelgrund added this to the 0.4.0 milestone May 23, 2021
Copy link
Member

@core-man core-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great~

@maxrjones
Copy link
Member

maxrjones commented May 23, 2021

Do you think that the inset box pen thickness is universally too thin with 6.2.0rc1, or just in this case since the pen color is not very bold? If it's a universal problem, we could try to fix the auto-scaling on the GMT side before 6.2.0.

@willschlitzer
Copy link
Contributor

willschlitzer commented May 24, 2021

Do you think that the inset box pen thickness is universally too thin with 6.2.0rc1, or just in this case since the pen color is not very bold? If it's a universal problem, we could try to fix the auto-scaling on the GMT side before 6.2.0.

I agree that the inset box thickness is too thin on 6.2rc1, as it looks too thin on both the light yellow border and the black border in the tutorial examples.

Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I notice that much of a difference between red and red3, but I think thickening the inset border is a smart move.

@michaelgrund
Copy link
Member Author

Do you think that the inset box pen thickness is universally too thin with 6.2.0rc1, or just in this case since the pen color is not very bold? If it's a universal problem, we could try to fix the auto-scaling on the GMT side before 6.2.0.

So far, I only noticed it in this example.

@michaelgrund
Copy link
Member Author

Can't say I notice that much of a difference between red and red3, but I think thickening the inset border is a smart move.

It's not a big difference, only looks a little bit more modern in my opinion 😄 , however, we could also leave it as is.

@maxrjones
Copy link
Member

FYI, the PR at GenericMappingTools/gmt#5265 will revert the default behavior for pen with +p to the 6.1 standard. Of course, this doesn't prevent setting it manually anyways as done here.

@michaelgrund michaelgrund self-assigned this May 27, 2021
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer maintenance Boring but important stuff for the core devs labels May 27, 2021
@seisman seisman changed the title Updates for inset gallery example Update the inset gallery example May 28, 2021
@seisman seisman merged commit f9c55c1 into master May 28, 2021
@seisman seisman deleted the update-gallery-inset branch May 28, 2021 02:37
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Will Schlitzer <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants