-
Notifications
You must be signed in to change notification settings - Fork 229
Update the inset gallery example #1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great~
Do you think that the inset box pen thickness is universally too thin with 6.2.0rc1, or just in this case since the pen color is not very bold? If it's a universal problem, we could try to fix the auto-scaling on the GMT side before 6.2.0. |
I agree that the inset box thickness is too thin on 6.2rc1, as it looks too thin on both the light yellow border and the black border in the tutorial examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't say I notice that much of a difference between red
and red3
, but I think thickening the inset border is a smart move.
So far, I only noticed it in this example. |
It's not a big difference, only looks a little bit more modern in my opinion 😄 , however, we could also leave it as is. |
FYI, the PR at GenericMappingTools/gmt#5265 will revert the default behavior for pen with +p to the 6.1 standard. Of course, this doesn't prevent setting it manually anyways as done here. |
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Will Schlitzer <[email protected]> Co-authored-by: Dongdong Tian <[email protected]>
Description of proposed changes
Increase the margin pen size of the inset box since after updating to GMT 6.2.0rc1 it appears to be too thin.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version