Skip to content

Update the baseline image for pygmt/test/test_plot.py:test_plot_matrix #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

seisman
Copy link
Member

@seisman seisman commented Sep 29, 2021

Description of proposed changes

See #1539 for the bug report and #1539 for the upstream fix.

Changes in this PR:

  • Changing incols="0,1,2+s0.005" to incols="0,1,2+s0.5" so that circils are large enough to be visible
  • Update the baseline image with the GMT master branch
  • Mark the test as xfail for GMT <= 6.2.0

Fixes #1539.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman force-pushed the fix-test_plot_matrix branch from 114e855 to f7d16e4 Compare September 29, 2021 07:58
@github-actions
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
modified pygmt/tests/baseline/test_plot_matrix.png

Image diff(s)

Added images

Modified images

Path Old New
test_plot_matrix.png

Report last updated at commit f7d16e4

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Sep 29, 2021
@seisman seisman added this to the 0.5.0 milestone Sep 29, 2021
@seisman seisman requested a review from maxrjones September 29, 2021 08:12
@seisman seisman merged commit a3ebfd5 into main Sep 29, 2021
@seisman seisman deleted the fix-test_plot_matrix branch September 29, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The baseline image for pygmt/test/test_plot.py:test_plot_matrix is wrong
2 participants