-
Notifications
You must be signed in to change notification settings - Fork 229
NEP29: Set minimum required version to Python 3.8+ #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michaelgrund! Just some suggestions to put quotes around the version numbers (otherwise Python 3.10 will be read as Python 3.1 in the future, see #1577). I'll reduce the diffs in #1577 a little so that it won't conflict with this PR (edit: done at fca7a68).
Co-authored-by: Wei Ji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michaelgrund, I've changed the PR's title and updated the required checks at https://github.com/GenericMappingTools/pygmt/settings. Just wait for a second approval before merging.
…ls#1676) Co-authored-by: Wei Ji <[email protected]>
Description of proposed changes
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version