-
Notifications
You must be signed in to change notification settings - Fork 228
load_earth_relief: Add the support of data source "GEBCO" #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 31 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
2916236
add GEBCO option for data_source
willschlitzer 80c389f
add parametrize to test_earth_relief_fails
willschlitzer 0d00c3d
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer 66ee213
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer 11310e3
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer db7ed8b
add tests at 01d resolution with and without region set for GEBCO data
willschlitzer d21df89
add check and testing for invalid data source
willschlitzer 5de32f3
Apply suggestions from code review
willschlitzer 1b88bf2
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer e1dc41f
Apply suggestions from code review
willschlitzer 16c3ac2
update reference information, remove specific version number for SRTM…
willschlitzer 1ff9ff8
change "relief" to "igpp"
willschlitzer 96b7059
update igpp docstring
willschlitzer 784ecd6
update remote file naming description
willschlitzer ac60440
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer 21d90a0
add error for old GMT version
willschlitzer e92927c
run make format
willschlitzer 8ab8050
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer b25fbca
fix GMT version checking
willschlitzer 7840b3f
create dictionary or earth_relief_sources
willschlitzer cc84324
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer 758e1fc
add data source check before checking version number
willschlitzer bd7507b
remove redundant check
willschlitzer d2b192e
Apply suggestions from code review
willschlitzer 921dd72
wording change in docstring
willschlitzer 90374b8
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer cc0dd5f
add 1d GEBCO dataset to testing.py
willschlitzer 94e0aaf
uncomment "pull_request" in cache_data.yaml to update GitHub cache
willschlitzer dffbbe1
disable pylint on too-many-branches in earth_relief.py
willschlitzer eb86bcf
re-comment "pull_request" in cache_data.yaml
willschlitzer e12c227
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer 77831ac
Apply suggestions from code review
willschlitzer 0567f63
move gebco file name for alaphbetizing
willschlitzer 0862cf2
move up else statement
willschlitzer 794d69b
change data source check
willschlitzer fe4ce30
add error handling for use_srtm
willschlitzer 0238d59
Merge remote-tracking branch 'origin/load-earth-relief/multiple-sourc…
willschlitzer 6f0a7d7
Merge branch 'main' into load-earth-relief/multiple-sources
willschlitzer 6fa396b
change elif statement to else statement, use dict.get
willschlitzer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.