Log error messages with a callback instead of file #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a callback function passed to `GMT_Create_Session` to log error messages instead of redirecting them to a file using `GMT_Handle_Messages`. It's a lot cleaner and the code is more legible. Other functions don't need to do anything to have their errors logged, it's automatic. The logged messaged are also printed to stderr so they will show up in the Jupyter notebook. This is useful when using the verbose mode (`V="d"`) in modules.
This was referenced Jun 16, 2018
This was referenced Jun 17, 2018
leouieda
pushed a commit
that referenced
this pull request
Jun 21, 2018
`ci` directory was removed in #188. Remove `ci` in `setup.py` and `.codeclimate.yml`.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a callback function passed to
GMT_Create_Sessionto log errormessages instead of redirecting them to a file using
GMT_Handle_Messages. It's a lot cleaner and the code is more legible.Other functions don't need to do anything to have their errors logged,
it's automatic.
The logged messaged are also printed to stderr so they will show up in
the Jupyter notebook.
This is useful when using the verbose mode (
V="d") in modules.Switch to the Fatiando a Terra CI scripts and enable OSX testing on
Travis to check if the Segfault in #164 is resolved.
Fatiando provides scripts for handling all of the CI tasks we need:
https://github.com/fatiando/continuous-integration
Use them instead of rewriting everything.