Skip to content

Remove title/label-whitespaces-trick from tests #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Remove title/label-whitespaces-trick from tests #2024

merged 2 commits into from
Jul 26, 2022

Conversation

yvonnefroehlich
Copy link
Member

Description of proposed changes

This PR removes the double-quote-trick to use whitespaces in titles and labels from a few tests.

Fixes #2018 (comment), #2013

Overview of affected tests

  • tests/test_basemap.py
  • tests/test_config.py
  • check if there are more affected tests

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Jul 25, 2022
@seisman seisman added this to the 0.8.0 milestone Jul 25, 2022
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Jul 25, 2022
@seisman seisman changed the title WIP: Remove title/label-whitespaces-trick from tests Remove title/label-whitespaces-trick from tests Jul 25, 2022
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing WIP and approving this PR, because I think these are all the affected tests.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jul 25, 2022
@yvonnefroehlich
Copy link
Member Author

Removing WIP and approving this PR, because I think these are all the affected tests.

This is fine for me. Thanks @seisman for checking this!

@seisman seisman merged commit 25530d9 into GenericMappingTools:main Jul 26, 2022
@yvonnefroehlich yvonnefroehlich deleted the remove-whitespace-trick-in-tests branch July 26, 2022 06:09
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label Aug 18, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants